Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.h

Issue 720883003: Adds a CloneAndAnimate function to WindowManagerInternalClient (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: tweaks Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_service_impl.h
diff --git a/mojo/services/view_manager/view_manager_service_impl.h b/mojo/services/view_manager/view_manager_service_impl.h
index 7395edd7bb8811c35c06135c6334bca9a5856925..f571b63780237b24de5ab99604731830b8c510c8 100644
--- a/mojo/services/view_manager/view_manager_service_impl.h
+++ b/mojo/services/view_manager/view_manager_service_impl.h
@@ -65,12 +65,24 @@ class ViewManagerServiceImpl : public ViewManagerService,
// Returns true if this connection's root is |id|.
bool IsRoot(const ViewId& id) const;
+ // Returns the id of the root node. This is null if the root has been
+ // destroyed but the connection is still valid.
+ const ViewId* root() const { return root_.get(); }
+
// Invoked when a connection is about to be destroyed.
void OnWillDestroyViewManagerServiceImpl(ViewManagerServiceImpl* connection);
- // Synchronous implementation of ViewManagerService::CreateView(), see the
- // mojom for details.
+ // These functions are synchronous variants of those defined in the mojom. The
+ // ViewManagerService implementations all call into these. See the mojom for
+ // details.
ErrorCode CreateView(const ViewId& view_id);
+ bool AddView(const ViewId& parent_id, const ViewId& child_id);
+ bool Embed(const std::string& url,
+ const ViewId& view_id,
+ InterfaceRequest<ServiceProvider> service_provider);
+ void GetViewTree(const ViewId& view_id,
msw 2014/11/18 23:37:43 nit: match the ordering of the mojom?
sky 2014/11/19 00:49:40 Done.
+ std::vector<const ServerView*>* views);
msw 2014/11/18 23:37:43 nit: return an std::vector<const ServerView*>?
sky 2014/11/19 00:49:40 Done.
+ bool SetViewVisibility(const ViewId& view_id, bool visible);
// The following methods are invoked after the corresponding change has been
// processed. They do the appropriate bookkeeping and update the client as

Powered by Google App Engine
This is Rietveld 408576698