Source/modules/serviceworkers/WaitUntilObserver.h - Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.h

Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: comments and test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/WaitUntilObserver.h

diff --git a/Source/modules/serviceworkers/WaitUntilObserver.h b/Source/modules/serviceworkers/WaitUntilObserver.h

index 3cad488bd04a8bf9ce2f5ab91f067cda9919d909..d64794f10e655771d0e9df655c4990599815311a 100644

--- a/Source/modules/serviceworkers/WaitUntilObserver.h

+++ b/Source/modules/serviceworkers/WaitUntilObserver.h

@@ -21,7 +21,9 @@ class WaitUntilObserver final : public GarbageCollectedFinalized<WaitUntilObserv

public:

enum EventType {

Activate,

- Install

+ Install,

+ NotificationClick,

+ NotificationError

};

static WaitUntilObserver* create(ExecutionContext*, EventType, int eventID);