Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl ('k') | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 19dc42267bdbfc224cf41dea85bc242b4585df12..8eb88fea0008873362531d34b24fa7161321e89e 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -64,6 +64,8 @@ public:

virtual void didHandleFetchEvent(int fetchEventID) = 0;

virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) = 0;

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) = 0;

+ virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) = 0;

Michael van Ouwerkerk 2014/11/12 18:12:46 Are we sorting alphabetically here, or something e

horo 2014/11/13 03:48:49 I don't have strong opinions. But it looks better

Peter Beverloo 2014/11/13 14:40:47 Done. I moved didHandleInstallEvent too.

+ virtual void didHandleNotificationErrorEvent(int eventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleSyncEvent(int syncEventID) = 0;

virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;