Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 720793004: Re-add dot_result_string to heap.h after 5f7b24f7b42 (Closed)

Created:
6 years, 1 month ago by adamk
Modified:
6 years, 1 month ago
Reviewers:
marja
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Re-add dot_result_string to heap.h after 5f7b24f7b42 Failed to notice it was still being used in a DCHECK, so removing it broke the debug build. TBR=marja@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c93c8969d1c9fbc6f926b9760cb3a230e644ea41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
adamk
6 years, 1 month ago (2014-11-12 18:34:00 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c93c8969d1c9fbc6f926b9760cb3a230e644ea41.

Powered by Google App Engine
This is Rietveld 408576698