DevTools: Replace visibleChildrenCount with hasVisibleChildren in ElementsTreeOutline.

Source/devtools/front_end/elements/ElementsTreeOutline.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 1417 matching lines @@
                 this.insertChild(this.expandAllButtonElement, targetButtonIndex);
             } else if (!this.expandAllButtonElement.parent)
                 this.insertChild(this.expandAllButtonElement, targetButtonIndex);
             this.expandAllButtonElement._button.textContent = WebInspector.UIString("Show All Nodes (%d More)", childNodeCount - expandedChildCount);
         } else if (this.expandAllButtonElement)
             delete this.expandAllButtonElement;
     },
 
     handleLoadAllChildren: function()
     {
-        this.expandedChildrenLimit = Math.max(this._visibleChildCount(), this.expandedChildrenLimit + WebInspector.ElementsTreeElement.InitialChildrenLimit);
+        var visibleChildCount = this._visibleChildren().length;
+        this.expandedChildrenLimit = Math.max(visibleChildCount, this.expandedChildrenLimit + WebInspector.ElementsTreeElement.InitialChildrenLimit);
     },
 
     expandRecursively: function()
     {
         /**
          * @this {WebInspector.ElementsTreeElement}
          */
         function callback()
         {
             TreeElement.prototype.expandRecursively.call(this, Number.MAX_VALUE);
@@ skipping 1273 matching lines @@
     /**
      * @return {!Array.<!WebInspector.DOMNode>} visibleChildren
      */
     _visibleChildren: function()
     {
         var visibleChildren = this._visibleShadowRoots();
         if (this._node.importedDocument())
             visibleChildren.push(this._node.importedDocument());
         if (this._node.templateContent())
             visibleChildren.push(this._node.templateContent());
-        var pseudoElements = this._node.pseudoElements();
-        if (pseudoElements[WebInspector.DOMNode.PseudoElementNames.Before])
-            visibleChildren.push(pseudoElements[WebInspector.DOMNode.PseudoElementNames.Before]);
+        var beforePseudoElement = this._node.beforePseudoElement();
+        if (beforePseudoElement)
+            visibleChildren.push(beforePseudoElement);
         if (this._node.childNodeCount())
             visibleChildren = visibleChildren.concat(this._node.children());
-        if (pseudoElements[WebInspector.DOMNode.PseudoElementNames.After])
-            visibleChildren.push(pseudoElements[WebInspector.DOMNode.PseudoElementNames.After]);
+        var afterPseudoElement = this._node.afterPseudoElement();
+        if (afterPseudoElement)
+            visibleChildren.push(afterPseudoElement);
         return visibleChildren;
     },
 
     /**
-     * @return {number}
+     * @return {boolean}
      */
-    _visibleChildCount: function()
+    _hasVisibleChildren: function()
     {
-        var childCount = this._node.childNodeCount() + this._visibleShadowRoots().length;
         if (this._node.importedDocument())
-            ++childCount;
+            return true;
         if (this._node.templateContent())
-            ++childCount;
-        for (var pseudoType in this._node.pseudoElements())
-            ++childCount;
-        return childCount;
+            return true;
+        if (this._node.childNodeCount())
+            return true;
+        if (this._visibleShadowRoots().length)
+            return true;
+        if (this._node.hasPseudoElements())
+            return true;
+        return false;
     },
 
     /**
      * @return {boolean}
      */
     _hasChildTreeElements: function()
     {
         return this._childrenDisplayMode === WebInspector.ElementsTreeElement.ChildrenDisplayMode.HasChildren;
     },
 
@@ skipping 11 matching lines @@
         var textChild = this._node.firstChild;
         var maxInlineTextChildLength = 80;
         if (textChild.nodeValue().length < maxInlineTextChildLength)
             return true;
         return false;
     },
 
     _updateChildrenDisplayMode: function()
     {
         var showInlineText = this._canShowInlineText();
-        var hasChildren = !this._elementCloseTag && this._visibleChildCount() > 0;
+        var hasChildren = !this._elementCloseTag && this._hasVisibleChildren();
 
         if (showInlineText)
             this._childrenDisplayMode = WebInspector.ElementsTreeElement.ChildrenDisplayMode.InlineText;
         else if (hasChildren)
             this._childrenDisplayMode = WebInspector.ElementsTreeElement.ChildrenDisplayMode.HasChildren;
         else
             this._childrenDisplayMode = WebInspector.ElementsTreeElement.ChildrenDisplayMode.NoChildren;
 
         this.setHasChildren(this._childrenDisplayMode === WebInspector.ElementsTreeElement.ChildrenDisplayMode.HasChildren);
     },
@@ skipping 361 matching lines @@
                 treeOutline.rootDOMNode = node;
                 if (!treeOutline.children[0].hasChildren)
                     treeOutline._element.classList.add("single-node");
                 treeOutline.setVisible(true);
                 treeOutline.element.treeElementForTest = treeOutline.children[0];
                 resolve(treeOutline.element);
             }
         }
     }
 }