Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 720753003: Remove implicit conversions from scoped_refptr to T* in ash/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
zturner
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in ash/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/4da4d40742403e9a9cad302473f4dce1745a149f Cr-Commit-Position: refs/heads/master@{#304113}

Patch Set 1 #

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ash/system/win/audio/tray_audio_delegate_win.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 1 month ago (2014-11-12 22:49:40 UTC) #2
zturner
lgtm Sorry about the slow response, I'm not actually working on chromium anymore, so this ...
6 years, 1 month ago (2014-11-13 21:56:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720753003/20001
6 years, 1 month ago (2014-11-13 22:00:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-13 23:31:00 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:36:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4da4d40742403e9a9cad302473f4dce1745a149f
Cr-Commit-Position: refs/heads/master@{#304113}

Powered by Google App Engine
This is Rietveld 408576698