Issue 720753002: NOT_FOR_COMMIT: Death Test for intercepting base::File Open/Close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 720753002: NOT_FOR_COMMIT: Death Test for intercepting base::File Open/Close

Created:
6 years, 1 month ago by pasko

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@cache-close

Project:
chromium

Visibility:
Public.

More Reviews

Description

NOT_FOR_COMMIT: Death Test for intercepting base::File Open/Close This does not work on Linux with tcmalloc because: 1. base_unittests allocate via tcmalloc 2. tcmalloc acquires its internal lock 3. then attempts ASLR, which requires closing /dev/urandom 4. in close() we attempt to allocate -> deadlock BUG=424562

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	base/base.gyp	View		2 chunks	+5 lines, -1 line	0 comments	Download
	A	base/files/protect_file_posix_unittest.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download