Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 720743003: Remove SK_USE_SCALED_FONTMETRICS. (Closed)

Created:
6 years, 1 month ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SK_USE_SCALED_FONTMETRICS. This define was added in "SK_USE_SCALED_FONTMETRICS for correct scaling" c17c6582ec0b7bc211d7de9e8d634692d239c123. Users all now define this flag, so it may now be removed. BUG=chromium:420901 Committed: https://skia.googlesource.com/skia/+/6fee786210bd2f9ef8d5d570530b05ef6cb02fa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
6 years, 1 month ago (2014-11-12 15:11:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720743003/1
6 years, 1 month ago (2014-11-12 15:16:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 15:16:34 UTC) #5
reed1
lgtm
6 years, 1 month ago (2014-11-12 16:28:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720743003/1
6 years, 1 month ago (2014-11-12 16:29:03 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 16:29:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6fee786210bd2f9ef8d5d570530b05ef6cb02fa1

Powered by Google App Engine
This is Rietveld 408576698