Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 720713003: Remove WebScroll* (Closed)

Created:
6 years, 1 month ago by rafaelw
Modified:
6 years, 1 month ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1362 lines) Patch
M sky/engine/platform/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D sky/engine/platform/exported/WebScrollbarImpl.h View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/engine/platform/exported/WebScrollbarImpl.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D sky/engine/platform/exported/WebScrollbarThemeGeometryNative.h View 1 chunk +0 lines, -66 lines 0 comments Download
D sky/engine/platform/exported/WebScrollbarThemeGeometryNative.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D sky/engine/platform/scroll/ProgrammaticScrollAnimator.h View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/engine/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 5 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 7 chunks +0 lines, -31 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 4 chunks +4 lines, -33 lines 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/public/platform/WebCompositorAnimationCurve.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/WebCompositorSupport.h View 3 chunks +0 lines, -7 lines 0 comments Download
D sky/engine/public/platform/WebScrollOffsetAnimationCurve.h View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/engine/public/platform/WebScrollbar.h View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/engine/public/platform/WebScrollbarBehavior.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/public/platform/WebScrollbarLayer.h View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/engine/public/platform/WebScrollbarThemeGeometry.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/public/platform/WebScrollbarThemePainter.h View 1 chunk +0 lines, -66 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/web/AssertMatchingEnums.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/web/WebScrollbarThemePainter.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M sky/viewer/cc/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D sky/viewer/cc/scrollbar_impl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/viewer/cc/scrollbar_impl.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M sky/viewer/cc/web_animation_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/viewer/cc/web_compositor_support_impl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/viewer/cc/web_compositor_support_impl.cc View 4 chunks +0 lines, -32 lines 0 comments Download
D sky/viewer/cc/web_scroll_offset_animation_curve_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/viewer/cc/web_scroll_offset_animation_curve_impl.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/viewer/cc/web_scrollbar_layer_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/viewer/cc/web_scrollbar_layer_impl.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rafaelw
6 years, 1 month ago (2014-11-12 23:25:23 UTC) #2
abarth-chromium
LGTM This CL removes a bunch of configurability from the scrollbar system, but I don't ...
6 years, 1 month ago (2014-11-13 00:38:16 UTC) #3
rafaelw
Committed patchset #1 (id:1) manually as 1c5bfb0236f1689b1b8f81e882c87f9e2aeac204 (presubmit successful).
6 years, 1 month ago (2014-11-13 00:41:23 UTC) #4
jamesr
I don't know how but this ended up checking in a subproject commit for tools/gyp/ ...
6 years, 1 month ago (2014-11-14 01:03:35 UTC) #6
jamesr
6 years, 1 month ago (2014-11-14 01:04:30 UTC) #7
Message was sent while issue was closed.
Think I fixed it:
https://github.com/domokit/mojo/commit/02b32f11dbffc023b3d5f849fb09e79dab51349d
(Although this stuff is super subtle)

Powered by Google App Engine
This is Rietveld 408576698