Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 720693003: Remove EventHandler::m_didStartDrag. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Remove EventHandler::m_didStartDrag. EventHandler maintains a ton of state, and making sure everything is in sync gets rather complicated. m_didStartDrag was only used as by gesture code, to detect if it should fall back to default handling. This patch changes handleDrag()'s CheckDragHysteresis parameter to DragIniator, which more accurately reflects how it's used. The updated parameter is also used to determine when default handling is needed, eliminating the need for the m_didStartDrag bool. Yay! BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M Source/core/page/EventHandler.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 9 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
Now EventHandler only has 51 members instead of 52!
6 years, 1 month ago (2014-11-13 21:29:57 UTC) #2
Rick Byers
Thanks for the clean-up! LGTM
6 years, 1 month ago (2014-11-13 22:14:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720693003/1
6 years, 1 month ago (2014-11-13 22:15:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36418)
6 years, 1 month ago (2014-11-14 00:03:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720693003/1
6 years, 1 month ago (2014-11-14 00:08:10 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 00:57:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185337

Powered by Google App Engine
This is Rietveld 408576698