Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 720683003: App list: Added DCHECK for custom page when switching profiles. (Closed)

Created:
6 years, 1 month ago by Matt Giuca
Modified:
6 years, 1 month ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

App list: Added DCHECK for custom page when switching profiles. This checks that the custom page's web contents belongs to the current profile. This DCHECK would previously have failed when switching profiles, but it should now always be true since crbug.com/392763 has been resolved. BUG=392763 Committed: https://crrev.com/535001b191a973f9615a2692831e7fdc357a6c08 Cr-Commit-Position: refs/heads/master@{#303806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
This DCHECK seems to be working fine now (as of r291852).
6 years, 1 month ago (2014-11-12 07:06:51 UTC) #2
tapted
lgtm. I guess these will never be incognito (so no need for profile_->IsSameProfile(..))
6 years, 1 month ago (2014-11-12 07:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720683003/1
6 years, 1 month ago (2014-11-12 08:07:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 09:01:34 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 09:02:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/535001b191a973f9615a2692831e7fdc357a6c08
Cr-Commit-Position: refs/heads/master@{#303806}

Powered by Google App Engine
This is Rietveld 408576698