New credential chooser bubble view.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/passwords/save_password_refusal_combobox_model.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
+#include "chrome/browser/ui/views/passwords/credentials_item_view.h"
 #include "chrome/browser/ui/views/passwords/manage_password_item_view.h"
 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/controls/button/blue_button.h"
@@ skipping 138 matching lines @@
     return;
   content::WebContents* bubble_web_contents =
       ManagePasswordsBubbleView::manage_password_bubble()->web_contents();
   if (web_contents == bubble_web_contents)
     ManagePasswordsBubbleView::CloseBubble();
 }
 
 }  // namespace chrome
 
 
+// ManagePasswordsBubbleView::AccountChooserView ------------------------------
+
+// A view offering the user the ability to save credentials. Contains a
+// single ManagePasswordItemView, along with a "Save Passwords" button
+// and a rejection combobox. -------------------------------------

[Mike West, 2014/11/13 10:06:26]

Nit: drop the ----- from this line.

[vasilii, 2014/11/13 12:00:19]

The whole comment was pure copy-paste.

+class ManagePasswordsBubbleView::AccountChooserView
+    : public views::View,
+      public views::ButtonListener {
+ public:
+  explicit AccountChooserView(ManagePasswordsBubbleView* parent);
+  ~AccountChooserView() override;
+
+ private:
+  // views::ButtonListener:
+  void ButtonPressed(views::Button* sender, const ui::Event& event) override;
+
+  ManagePasswordsBubbleView* parent_;
+  views::LabelButton* cancel_button_;
+};
+
+ManagePasswordsBubbleView::AccountChooserView::AccountChooserView(
+    ManagePasswordsBubbleView* parent)
+    : parent_(parent) {
+  views::GridLayout* layout = new views::GridLayout(this);
+  SetLayoutManager(layout);
+
+  cancel_button_ =
+      new views::LabelButton(this, l10n_util::GetStringUTF16(IDS_CANCEL));
+  cancel_button_->SetStyle(views::Button::STYLE_BUTTON);
+  cancel_button_->SetFontList(
+      ui::ResourceBundle::GetSharedInstance().GetFontList(
+          ui::ResourceBundle::SmallFont));
+
+  // Title row.
+  BuildColumnSet(layout, SINGLE_VIEW_COLUMN_SET);
+  AddTitleRow(layout, parent_->model());
+
+  for (int i = 0; i < 2; ++i) {
+    base::string16 name =
+        l10n_util::GetStringFUTF16Int(IDS_NUMBERED_PROFILE_NAME, i);

[Mike West, 2014/11/13 10:06:26]

This doesn't seem robust. Is this going to crash if a user only has one profile?

More generally, I'm fine with using the profiles as a placeholder for data, but
please:

1. Move the enumeration of profiles to a method on either the
ManagePasswordsBubbleView or the Model. This view shouldn't be generating it's
own data, even as a stub.

2. Add comments so that it's clear that you're just stubbing out the
functionality.

[vasilii, 2014/11/13 12:00:19]

It just reads the string "User $1" from the resource and changes the parameter
to 0 or 1. It has nothing to do with the actual profiles.

+    CredentialsItemView* credential_view = new CredentialsItemView(this, name);
+    // Add the title to the layout with appropriate padding.
+    layout->StartRow(0, SINGLE_VIEW_COLUMN_SET);
+    layout->AddView(credential_view);

[Mike West, 2014/11/13 10:06:26]

Where do you plan to handle clicks on individual credentials? Will the subviews
bubble clicks up to this view, or will you handle everything in the subview?

[vasilii, 2014/11/13 12:00:19]

That's a good question. For consistency with other classes I'll handle them in
AccountChooserView. I don't know if it's the best strategy.

+  }
+
+  // Button row.
+  BuildColumnSet(layout, SINGLE_BUTTON_COLUMN_SET);
+  layout->StartRowWithPadding(
+      0, SINGLE_BUTTON_COLUMN_SET, 0, views::kRelatedControlVerticalSpacing);
+  layout->AddView(cancel_button_);
+
+  // Extra padding for visual awesomeness.
+  layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
+
+  parent_->set_initially_focused_view(cancel_button_);
+}
+
+ManagePasswordsBubbleView::AccountChooserView::~AccountChooserView() {
+}
+
+void ManagePasswordsBubbleView::AccountChooserView::ButtonPressed(
+    views::Button* sender, const ui::Event& event) {
+  parent_->Close();
+}
+
 // ManagePasswordsBubbleView::PendingView -------------------------------------
 
 // A view offering the user the ability to save credentials. Contains a
 // single ManagePasswordItemView, along with a "Save Passwords" button
 // and a rejection combobox.
 class ManagePasswordsBubbleView::PendingView : public views::View,
                                                public views::ButtonListener,
                                                public views::ComboboxListener {
  public:
   explicit PendingView(ManagePasswordsBubbleView* parent);
@@ skipping 680 matching lines @@
 }
 
 void ManagePasswordsBubbleView::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(type, chrome::NOTIFICATION_FULLSCREEN_CHANGED);
   GetWidget()->SetVisibilityAnimationTransition(views::Widget::ANIMATE_NONE);
   CloseBubble();
 }