LayoutTests/fast/events/message-port-start-and-close-same-microtask.html - Issue 720543005: Fix MessagePort race exposed by blink scheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/message-port-start-and-close-same-microtask.html

Issue 720543005: Fix MessagePort race exposed by blink scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test descriptions which had got mixed up. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/events/message-port-start-and-close-same-microtask.html

diff --git a/LayoutTests/fast/events/message-port-close.html b/LayoutTests/fast/events/message-port-start-and-close-same-microtask.html

similarity index 62%

copy from LayoutTests/fast/events/message-port-close.html

copy to LayoutTests/fast/events/message-port-start-and-close-same-microtask.html

index 0dabcd830f60b1ba2cd64a5034db250616fb1fd5..5f08ab3fa45ad7bdf46f1f1c99451b76a25a5c89 100644

--- a/LayoutTests/fast/events/message-port-close.html

+++ b/LayoutTests/fast/events/message-port-start-and-close-same-microtask.html

@@ -1,5 +1,5 @@

<body>

-Test Closed MessagePort Whether Receive Message Or Not.

+Test whether opening and closing a messageport in the same microtask correctly discards an in-flight message.

Should be a START message, followed with DONE.

@@ -16,13 +16,19 @@ if (window.testRunner) {

log("START");

var channel = new MessageChannel;

-channel.port1.onmessage = function(evt) {

- log("Closed port receiving: FAIL. Got Message: " + evt.data + " after close");

-channel.port1.close();

channel.port2.postMessage("This message can't be received");

+openThenClose();

done();

+function openThenClose() {

+ setTimeout(function() {

+ channel.port1.onmessage = function(evt) {

+ log("Closed port receiving: FAIL. Got Message: " + evt.data + " after close");

+ }

+ channel.port1.close();

+ }, 0);

function done() {

// Wait a short period of time to ensure no messages come in from previous tests.

setTimeout(function() {