Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 720513002: [NaCl SDk] Update naclports revision used to build SDK (Closed)

Created:
6 years, 1 month ago by Sam Clegg
Modified:
6 years, 1 month ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDk] Update naclports revision used to build SDK This brings in 98 revsions from the naclports repo between 0c21fc5..796184d. This change is needed to fix the build on chrome release branches. The critical change needed is: 796184d Check SDK major version as well as revision BUG=432273 R=binji@chromium.org Committed: https://crrev.com/0e54a112d3ecef9992d67ec0b742ed3d591db691 Cr-Commit-Position: refs/heads/master@{#303859}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 chunks +4 lines, -6 lines 2 comments Download
M native_client_sdk/src/gonacl_appengine/src/bullet/build.sh View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/lua/build.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Sam Clegg
6 years, 1 month ago (2014-11-11 22:15:53 UTC) #1
binji
lgtm https://codereview.chromium.org/720513002/diff/20001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/720513002/diff/20001/native_client_sdk/src/build_tools/build_sdk.py#newcode968 native_client_sdk/src/build_tools/build_sdk.py:968: options.build_app_engine = True we can try re-enabling this, ...
6 years, 1 month ago (2014-11-11 22:25:13 UTC) #3
Sam Clegg
https://codereview.chromium.org/720513002/diff/20001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/720513002/diff/20001/native_client_sdk/src/build_tools/build_sdk.py#newcode968 native_client_sdk/src/build_tools/build_sdk.py:968: options.build_app_engine = True On 2014/11/11 22:25:13, binji wrote: > ...
6 years, 1 month ago (2014-11-11 22:57:50 UTC) #4
Sam Clegg
Committed patchset #2 (id:20001) manually as 0e54a112d3ecef9992d67ec0b742ed3d591db691 (presubmit successful).
6 years, 1 month ago (2014-11-12 18:32:27 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:32:34 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e54a112d3ecef9992d67ec0b742ed3d591db691
Cr-Commit-Position: refs/heads/master@{#303859}

Powered by Google App Engine
This is Rietveld 408576698