Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 720443002: Add a PushClient getter in WebFrameTestProxy. (Closed)

Created:
6 years, 1 month ago by Michael van Ouwerkerk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a PushClient getter in WebFrameTestProxy. BUG=304341, 350378 Committed: https://crrev.com/f25dd9c51401c8d4f91ab497eebdda41aa272df7 Cr-Commit-Position: refs/heads/master@{#303685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael van Ouwerkerk
Hi Peter, could you please take a look?
6 years, 1 month ago (2014-11-11 17:53:33 UTC) #2
Michael van Ouwerkerk
Mike, could you please take a look as owner?
6 years, 1 month ago (2014-11-11 17:54:09 UTC) #4
Peter Beverloo
On 2014/11/11 17:54:09, Michael van Ouwerkerk wrote: > Mike, could you please take a look ...
6 years, 1 month ago (2014-11-11 17:57:51 UTC) #5
Peter Beverloo
On 2014/11/11 17:57:51, Peter Beverloo wrote: > On 2014/11/11 17:54:09, Michael van Ouwerkerk wrote: > ...
6 years, 1 month ago (2014-11-11 17:58:58 UTC) #6
Mike West
LGTM
6 years, 1 month ago (2014-11-11 18:16:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720443002/1
6 years, 1 month ago (2014-11-11 18:19:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 19:21:35 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 19:22:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f25dd9c51401c8d4f91ab497eebdda41aa272df7
Cr-Commit-Position: refs/heads/master@{#303685}

Powered by Google App Engine
This is Rietveld 408576698