tools/perf/benchmarks/benchmark_smoke_unittest.py - Issue 720413006: [Telemetry] Improve elevate_privilege handling in LaunchApplication() + Fix killing of power metri…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 720413006: [Telemetry] Improve elevate_privilege handling in LaunchApplication() + Fix killing of power metri… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_smoke_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py

index ca454d72f464e4e22d13134ce1e8840349e5f06f..bed257ebb9736c0a777a899a4fc23aed7018d43f 100644

--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py

+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py

@@ -26,9 +26,7 @@ def SmokeTestGenerator(benchmark):

# failing or flaky benchmark would disable a much wider swath of coverage

# than is usally intended. Instead, if a particular benchmark is failing,

# disable it in tools/perf/benchmarks/*.

- # EXCEPTIONS TO THE ABOVE RULE: crbug.com/351114, crbug.com/423688

- @benchmark_module.Disabled('chromeos', 'mavericks')

+ @benchmark_module.Disabled('chromeos') # crbug.com/351114

def BenchmarkSmokeTest(self):

# Only measure a single page so that this test cycles reasonably quickly.

benchmark.options['pageset_repeat'] = 1

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/platform_backend_unittest.py » ('j') | no next file with comments »