Let input tag filter out non-native files in dropped data.

Let input tag filter out non-native files in dropped data.

To fix crbug.com/126766, we stopped to create snapshot files for non-natvie
files at the beginning of drag operations. It causes files having empty paths
are reaches to input tag, and thus renderer process crashes.

BUG=407568
TEST=FileInputTypeTest.ignoreDroppedNonNativeFiles

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185434

[hirono, 2014-11-14 04:30:46]

hirono@chromium.org changed reviewers:
+ tkent@chromium.org

[hirono, 2014-11-14 04:30:46]

Please take a look the CL? Thanks!

[tkent, 2014-11-14 06:49:27]

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
File Source/core/html/forms/FileInputType.cpp (right):

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputType.cpp:366:
filesChosen(Vector<FileChooserFileInfo>());
This behavior looks inconsistent.
If non-files are dropped, we don't change existing file selection.  See the
beginning of this function.

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
File Source/core/html/forms/FileInputTypeTest.cpp (right):

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputTypeTest.cpp:53:
HTMLInputElement::create(*document, 0, /* createdByParser */true);
nit: 0 -> nullptr

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputTypeTest.cpp:57: const DragData
dragData(DataObject::create().get(), IntPoint(0, 0), IntPoint(0, 0),
DragOperationCopy);
nit: IntPoint(0, 0) -> IntPoint()

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputTypeTest.cpp:66: const DragData
dragData(DataObject::create().get(), IntPoint(0, 0), IntPoint(0, 0),
DragOperationCopy);
Ditto.

[hirono, 2014-11-17 05:11:22]

Thanks!

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
File Source/core/html/forms/FileInputType.cpp (right):

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputType.cpp:366:
filesChosen(Vector<FileChooserFileInfo>());
On 2014/11/14 06:49:27, tkent wrote:
> This behavior looks inconsistent.
> If non-files are dropped, we don't change existing file selection.  See the
> beginning of this function.

Done.

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
File Source/core/html/forms/FileInputTypeTest.cpp (right):

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputTypeTest.cpp:53:
HTMLInputElement::create(*document, 0, /* createdByParser */true);
On 2014/11/14 06:49:27, tkent wrote:
> nit: 0 -> nullptr

Done.

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputTypeTest.cpp:57: const DragData
dragData(DataObject::create().get(), IntPoint(0, 0), IntPoint(0, 0),
DragOperationCopy);
On 2014/11/14 06:49:27, tkent wrote:
> nit: IntPoint(0, 0) -> IntPoint()

Done.

https://codereview.chromium.org/720403002/diff/20001/Source/core/html/forms/F...
Source/core/html/forms/FileInputTypeTest.cpp:66: const DragData
dragData(DataObject::create().get(), IntPoint(0, 0), IntPoint(0, 0),
DragOperationCopy);
On 2014/11/14 06:49:27, tkent wrote:
> Ditto.

Done.

[tkent, 2014-11-17 05:21:37]

https://codereview.chromium.org/720403002/diff/60001/Source/core/page/DragCon...
File Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/720403002/diff/60001/Source/core/page/DragCon...
Source/core/page/DragController.cpp:57: #include
"core/html/forms/FileInputType.h"
Please do not include FileInputType.h here.  *InputType.h should be used only in
HTMLInputElement.
Probably getAcceptableDropFileNames() should be a function of DragController.

[hirono, 2014-11-17 05:59:25]

https://codereview.chromium.org/720403002/diff/60001/Source/core/page/DragCon...
File Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/720403002/diff/60001/Source/core/page/DragCon...
Source/core/page/DragController.cpp:57: #include
"core/html/forms/FileInputType.h"
On 2014/11/17 05:21:37, tkent wrote:
> Please do not include FileInputType.h here.  *InputType.h should be used only
in
> HTMLInputElement.
> Probably getAcceptableDropFileNames() should be a function of DragController.

Done.

[tkent, 2014-11-17 06:45:08]

I'm sorry I still have comments requiring a major change.

* We should remove DragData::numberOfFiles(). It's harmful and we should not use
it.

* getAcceptableDropFileNames can be merged into DragData::asFilenames().  It
seems no other callsites of asFilenames().

[hirono, 2014-11-17 07:50:34]

Thank you for catching the unused lines. Done!

[tkent, 2014-11-17 08:09:47]

lgtm

https://codereview.chromium.org/720403002/diff/100001/Source/core/html/forms/...
File Source/core/html/forms/FileInputType.cpp (right):

https://codereview.chromium.org/720403002/diff/100001/Source/core/html/forms/...
Source/core/html/forms/FileInputType.cpp:36: #include
"core/page/DragController.h"
Remove this.

https://codereview.chromium.org/720403002/diff/100001/Source/core/page/DragDa...
File Source/core/page/DragData.h (right):

https://codereview.chromium.org/720403002/diff/100001/Source/core/page/DragDa...
Source/core/page/DragData.h:68: void asFilePaths(Vector<String>&) const;
I'm not sure why you renamed this.

[hirono, 2014-11-17 08:14:45]

https://codereview.chromium.org/720403002/diff/100001/Source/core/html/forms/...
File Source/core/html/forms/FileInputType.cpp (right):

https://codereview.chromium.org/720403002/diff/100001/Source/core/html/forms/...
Source/core/html/forms/FileInputType.cpp:36: #include
"core/page/DragController.h"
On 2014/11/17 08:09:46, tkent wrote:
> Remove this.

Done.

https://codereview.chromium.org/720403002/diff/100001/Source/core/page/DragDa...
File Source/core/page/DragData.h (right):

https://codereview.chromium.org/720403002/diff/100001/Source/core/page/DragDa...
Source/core/page/DragData.h:68: void asFilePaths(Vector<String>&) const;
On 2014/11/17 08:09:46, tkent wrote:
> I'm not sure why you renamed this.

The values are come from blink::File class having both name() and path() fields.
So I'd like to make it clear which property is referred.

[hirono, 2014-11-17 08:15:12]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-11-17 08:15:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720403002/120001

[commit-bot: I haz the power, 2014-11-17 08:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-17 08:26:51]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[hirono, 2014-11-17 10:00:03]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-11-17 10:00:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720403002/140001

[commit-bot: I haz the power, 2014-11-17 12:20:45]

Committed patchset #8 (id:140001) as 185434