Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 720373004: Remove wincrypt.h from precompiled headers. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove wincrypt.h from precompiled headers. wincrypt.h and OpenSSL conflict on a symbol, worked around by crypto/wincrypt_shim.h. This means that wincrypt.h can't be included directly. Remove it from the set of precompiled headers. BUG=338884 Committed: https://crrev.com/cd99594892b5813dd9fd9c96893337f23ca638de Cr-Commit-Position: refs/heads/master@{#304880}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/precompile.h View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 11 (3 generated)
davidben
This is making the win_drmemory bot grumpy when flipping use_openssl=1. I'm not sure why it ...
6 years, 1 month ago (2014-11-19 19:38:28 UTC) #2
davidben
Also +rsleevi in case he has strong opinions.
6 years, 1 month ago (2014-11-19 19:41:36 UTC) #4
scottmg
Yes, most bots do not use PCH because goma does not support PCH. https://codereview.chromium.org/720373004/diff/1/build/precompile.h File ...
6 years, 1 month ago (2014-11-19 19:42:42 UTC) #5
scottmg
I guess we don't put non-system headers in here. LGTM.
6 years, 1 month ago (2014-11-19 19:43:16 UTC) #6
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-11-19 19:47:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720373004/1
6 years, 1 month ago (2014-11-19 19:50:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 20:34:26 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 20:36:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd99594892b5813dd9fd9c96893337f23ca638de
Cr-Commit-Position: refs/heads/master@{#304880}

Powered by Google App Engine
This is Rietveld 408576698