Add FakeClipboard implementation for unit tests.

Add TestClipboard implementation for unit tests.

BUG=319285
Committed: https://crrev.com/dd4f545ea9d92615328e39aa24254f1e01144083
Cr-Commit-Position: refs/heads/master@{#304688}

[dcheng, 2014-11-14 01:06:14]

dcheng@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-11-14 02:10:31]

LGTM with a better name.

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
File ui/base/clipboard/clipboard.h (right):

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
ui/base/clipboard/clipboard.h:191: // Testing helper to Replace any clipboard
for the current thread with a fake
Why the caps for Replace?

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
ui/base/clipboard/clipboard.h:193: static void UseFakeForCurrentThreadForTest();
How about UseTestClipboardForCurrentThread? Or Mock if you prefer. But I think
Test better matches what it is.

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
File ui/base/clipboard/clipboard_unittest.cc (right):

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
ui/base/clipboard/clipboard_unittest.cc:99: struct FakeClipboardTraits {
TestClipboardTraits

https://codereview.chromium.org/720373003/diff/80001/ui/base/test/fake_clipbo...
File ui/base/test/fake_clipboard.h (right):

https://codereview.chromium.org/720373003/diff/80001/ui/base/test/fake_clipbo...
ui/base/test/fake_clipboard.h:14: class FakeClipboard : public Clipboard {
TestClipboard.

https://codereview.chromium.org/720373003/diff/80001/ui/base/test/fake_clipbo...
ui/base/test/fake_clipboard.h:77: };
DISALLOW...

[dcheng, 2014-11-14 03:30:29]

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
File ui/base/clipboard/clipboard.h (right):

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
ui/base/clipboard/clipboard.h:191: // Testing helper to Replace any clipboard
for the current thread with a fake
On 2014/11/14 02:10:31, sky wrote:
> Why the caps for Replace?

Done.

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
ui/base/clipboard/clipboard.h:193: static void UseFakeForCurrentThreadForTest();
On 2014/11/14 02:10:31, sky wrote:
> How about UseTestClipboardForCurrentThread? Or Mock if you prefer. But I think
> Test better matches what it is.

Done.

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
File ui/base/clipboard/clipboard_unittest.cc (right):

https://codereview.chromium.org/720373003/diff/80001/ui/base/clipboard/clipbo...
ui/base/clipboard/clipboard_unittest.cc:99: struct FakeClipboardTraits {
On 2014/11/14 at 02:10:31, sky wrote:
> TestClipboardTraits

Done.

https://codereview.chromium.org/720373003/diff/80001/ui/base/test/fake_clipbo...
File ui/base/test/fake_clipboard.h (right):

https://codereview.chromium.org/720373003/diff/80001/ui/base/test/fake_clipbo...
ui/base/test/fake_clipboard.h:14: class FakeClipboard : public Clipboard {
On 2014/11/14 at 02:10:31, sky wrote:
> TestClipboard.

Done.

https://codereview.chromium.org/720373003/diff/80001/ui/base/test/fake_clipbo...
ui/base/test/fake_clipboard.h:77: };
On 2014/11/14 at 02:10:31, sky wrote:
> DISALLOW...

Done.

[dcheng, 2014-11-14 03:30:33]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-11-14 03:31:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720373003/100001

[commit-bot: I haz the power, 2014-11-14 04:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-14 04:17:13]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dcheng, 2014-11-17 20:09:55]

PTAL. I had to make a few changes to make things happy.

1) I moved the test type parameterization into its own header, so the test
clipboard tests can stay under ui_unittests (since serial test execution is
pretty slow).
2) I got rid of MarkupMatches in clipboard_test_template.h and made the matches
more exact. This should let the output from gtest be more descriptive too, since
we can use EXPECT_EQ directly now.
3) I moved UseTestClipboardForCurrentThread() to TestClipboard to avoid issues
with the component build.

[sky, 2014-11-17 20:35:46]

LGTM

[dcheng, 2014-11-18 22:08:12]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-11-18 22:09:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720373003/200001

[commit-bot: I haz the power, 2014-11-18 22:58:24]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2014-11-18 22:59:10]

Patchset 11 (id:??) landed as
https://crrev.com/dd4f545ea9d92615328e39aa24254f1e01144083
Cr-Commit-Position: refs/heads/master@{#304688}