Subzero: Simplify the FakeKill instruction.

src/IceOperand.h

Index: src/IceOperand.h
diff --git a/src/IceOperand.h b/src/IceOperand.h
index 5e0c02d84b7f261572548c8b3bea2d1a95d2d48e..c37b195415d78807a42e4eb3d1e83b4464bd327c 100644
--- a/src/IceOperand.h
+++ b/src/IceOperand.h
@@ -309,17 +309,15 @@ bool operator==(const RegWeight &A, const RegWeight &B);
 // weight, in case e.g. we want a live range to have higher weight
 // inside a loop.
 class LiveRange {
-  // LiveRange(const LiveRange &) = delete;
-  // LiveRange &operator=(const LiveRange &) = delete;

[jvoung (off chromium), 2014/11/14 17:01:09]

Oh, also I didn't spot where this change was needed (new use in a vector?), so
just checking if this is actually for a later change or maybe I just missed it.

[Jim Stichnoth, 2014/11/14 18:27:02]

Sorry, this was just cleanup while I was in the neighborhood.  Based on Roland's
suggestion in https://codereview.chromium.org/643903006/ .

-
 public:
-  LiveRange() : Weight(0), IsNonpoints(false) {}
+  LiveRange() : Weight(0) {}
+  LiveRange(const LiveRange &) = default;
+  LiveRange &operator=(const LiveRange &) = default;
 
   void reset() {
     Range.clear();
     Weight.setWeight(0);
     untrim();
-    IsNonpoints = false;
   }
   void addSegment(InstNumberT Start, InstNumberT End);
 
@@ -328,7 +326,6 @@ public:
   bool overlapsInst(InstNumberT OtherBegin, bool UseTrimmed = false) const;
   bool containsValue(InstNumberT Value, bool IsDest) const;
   bool isEmpty() const { return Range.empty(); }
-  bool isNonpoints() const { return IsNonpoints; }
   InstNumberT getStart() const {
     return Range.empty() ? -1 : Range.begin()->first;
   }
@@ -365,11 +362,6 @@ private:
   // that linear-scan also has to initialize TrimmedBegin at the
   // beginning by calling untrim().
   RangeType::const_iterator TrimmedBegin;
-  // IsNonpoints keeps track of whether the live range contains at
-  // least one interval where Start!=End.  If it is empty or has the
-  // form [x,x),[y,y),...,[z,z), then overlaps(InstNumberT) is
-  // trivially false.
-  bool IsNonpoints;
 };
 
 Ostream &operator<<(Ostream &Str, const LiveRange &L);