Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 72033002: Added the ability to set the upload file path (Closed)

Created:
7 years, 1 month ago by Noam Samuel
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added the ability to set the upoad file path Added the upload file path to PrivetURLFetcher and PrivetLocalPrintOperation. BUG=318373 R=gene@chromium.org, vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235658

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -27 lines) Patch
M chrome/browser/local_discovery/privet_http.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 2 3 chunks +29 lines, -9 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 2 3 chunks +36 lines, -15 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.h View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 1 2 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Noam Samuel
7 years, 1 month ago (2013-11-13 20:13:50 UTC) #1
gene
lgtm https://codereview.chromium.org/72033002/diff/1/chrome/browser/local_discovery/privet_http_impl.cc File chrome/browser/local_discovery/privet_http_impl.cc (right): https://codereview.chromium.org/72033002/diff/1/chrome/browser/local_discovery/privet_http_impl.cc#newcode498 chrome/browser/local_discovery/privet_http_impl.cc:498: url_fetcher_->SetUploadFilePath( nit: fit on one line https://codereview.chromium.org/72033002/diff/1/chrome/browser/local_discovery/privet_http_impl.cc#newcode502 chrome/browser/local_discovery/privet_http_impl.cc:502: ...
7 years, 1 month ago (2013-11-14 00:52:14 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2013/11/14 00:52:14, gene wrote: > lgtm > > https://codereview.chromium.org/72033002/diff/1/chrome/browser/local_discovery/privet_http_impl.cc > File chrome/browser/local_discovery/privet_http_impl.cc (right): > ...
7 years, 1 month ago (2013-11-14 08:27:07 UTC) #3
Noam Samuel
https://codereview.chromium.org/72033002/diff/1/chrome/browser/local_discovery/privet_http_impl.cc File chrome/browser/local_discovery/privet_http_impl.cc (right): https://codereview.chromium.org/72033002/diff/1/chrome/browser/local_discovery/privet_http_impl.cc#newcode498 chrome/browser/local_discovery/privet_http_impl.cc:498: url_fetcher_->SetUploadFilePath( On 2013/11/14 00:52:14, gene wrote: > nit: fit ...
7 years, 1 month ago (2013-11-14 19:05:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/72033002/120001
7 years, 1 month ago (2013-11-14 19:12:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=190045
7 years, 1 month ago (2013-11-14 20:03:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/72033002/120001
7 years, 1 month ago (2013-11-15 07:09:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=54269
7 years, 1 month ago (2013-11-15 09:35:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/72033002/120001
7 years, 1 month ago (2013-11-15 18:40:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/72033002/120001
7 years, 1 month ago (2013-11-15 22:28:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/72033002/120001
7 years, 1 month ago (2013-11-16 01:07:47 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=54596
7 years, 1 month ago (2013-11-16 03:58:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/72033002/680001
7 years, 1 month ago (2013-11-17 03:09:56 UTC) #13
Vitaly Buka (NO REVIEWS)
7 years, 1 month ago (2013-11-18 08:18:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 manually as r235658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698