Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 720323003: Disable LayerTreeHostTestCrispUpAfterPinchEndsWithOneCopy (Closed)

Created:
6 years, 1 month ago by vabr (Chromium)
Modified:
6 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720323003/1
6 years, 1 month ago (2014-11-17 08:33:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 09:21:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6add9f23542195020a69db646597b15d8963e35a Cr-Commit-Position: refs/heads/master@{#304397}
6 years, 1 month ago (2014-11-17 09:22:31 UTC) #4
danakj
https://codereview.chromium.org/720323003/diff/1/cc/trees/layer_tree_host_unittest.cc File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/720323003/diff/1/cc/trees/layer_tree_host_unittest.cc#newcode5586 cc/trees/layer_tree_host_unittest.cc:5586: #if !defined(OS_LINUX) || defined(NDEBUG) We could just disable it ...
6 years, 1 month ago (2014-11-17 16:03:06 UTC) #5
vabr (Chromium)
6 years, 1 month ago (2014-11-17 16:11:29 UTC) #6
Message was sent while issue was closed.
On 2014/11/17 16:03:06, danakj wrote:
>
https://codereview.chromium.org/720323003/diff/1/cc/trees/layer_tree_host_uni...
> File cc/trees/layer_tree_host_unittest.cc (right):
> 
>
https://codereview.chromium.org/720323003/diff/1/cc/trees/layer_tree_host_uni...
> cc/trees/layer_tree_host_unittest.cc:5586: #if !defined(OS_LINUX) ||
> defined(NDEBUG)
> We could just disable it entirely, the flake is nothing platform specific, but
> LGTM

OK, sorry about that. If there is a next time I'm disabling this, I'll just
comment the test out, like you did last week.

Cheers,
Vaclav

Powered by Google App Engine
This is Rietveld 408576698