Adding ChunkDemuxer implementation.

media/base/data_buffer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A simple implementation of Buffer that takes ownership of the given data
 // pointer.
 //
 // DataBuffer assumes that memory was allocated with new uint8[].
 
 #ifndef MEDIA_BASE_DATA_BUFFER_H_
 #define MEDIA_BASE_DATA_BUFFER_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "media/base/buffers.h"
 
 namespace media {
 
 class DataBuffer : public Buffer {
  public:
   // Takes ownership of the passed |buffer|, assumes valid data of size
   // |buffer_size|.
   DataBuffer(uint8* buffer, size_t buffer_size);
 
+  // Takes ownership of |buffer| if |copy| is false. If |copy| is true,
+  // a copy is made of |buffer|. Assumes |buffer_size| is the actual size
+  // of |buffer|.
+  DataBuffer(uint8* buffer, size_t buffer_size, bool copy);

[scherkus (not reviewing), 2011/06/23 18:50:18]

I don't think we should have this ctor:
  a) boolean arguments aren't very clear
  b) passing false is equivalent to the first ctor
  c) there are only 2 callees

this is where Go is kind of awesome because instead of having ctors you have
static methods like "NewDataBufferWithCopiedData". anyway I think a helper
method inside your ChunkDemuxer would do the trick

note: the ctor below where you pass in a buffer size should die -- it's only
used to create EOS buffers by passing in 0, but that would be better suited with
a "EndOfStreamBuffer" subclass or something like that :)

[acolwell GONE FROM CHROMIUM, 2011/06/23 22:42:17]

Done.

+
   // Allocates buffer of size |buffer_size|. If |buffer_size| is 0, |data_| is
   // set to a NULL ptr.
   explicit DataBuffer(size_t buffer_size);
 
   // Buffer implementation.
   virtual const uint8* GetData() const;
   virtual size_t GetDataSize() const;
 
   // Returns a read-write pointer to the buffer data.
   virtual uint8* GetWritableData();
@@ skipping 12 matching lines @@
   scoped_array<uint8> data_;
   size_t buffer_size_;
   size_t data_size_;
 
   DISALLOW_COPY_AND_ASSIGN(DataBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DATA_BUFFER_H_