Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 720283002: Revert of Revert "Only allow background tabs if the underlying input event allows it" (Closed)

Created:
6 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Stephen White
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Revert "Only allow background tabs if the underlying input event allows it" (patchset #1 id:1 of https://codereview.chromium.org/721793002/) Reason for revert: Removed failing browser test Original issue's description: > Revert "Only allow background tabs if the underlying input event allows it" > > This reverts commit c67fa612fedd3cf79f999ad61f2022dec85ff032, aka r185205. > > Speculative revert to green up browser_tests: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PrerenderBrowserTest.PrerenderClickNewBackgroundTab > > TBR=jochen@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185220 TBR=senorblanco@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
Created Revert of Revert "Only allow background tabs if the underlying input event allows it"
6 years, 1 month ago (2014-11-13 19:40:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720283002/1
6 years, 1 month ago (2014-11-13 19:41:59 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 20:47:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185318

Powered by Google App Engine
This is Rietveld 408576698