Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 720233006: [turbofan] Remove obsolete pure flag. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete pure flag. Use the Operator::kPure flag instead, which determines whether the JS operator has effect/control edges. R=mstarzinger@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/a92adc5803a34590598317b2a3a029fd5307c5a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M src/compiler/js-generic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years ago (2014-12-08 11:21:40 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-08 11:22:26 UTC) #2
Michael Starzinger
LGTM.
6 years ago (2014-12-08 11:24:54 UTC) #3
Benedikt Meurer
6 years ago (2014-12-08 11:25:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a92adc5803a34590598317b2a3a029fd5307c5a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698