Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: native_client_sdk/src/tools/tests/chrome_mock.py

Issue 720233003: [NaCl SDK] Convert python scripts from optparse to argparse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tools/tests/chrome_mock.py
diff --git a/native_client_sdk/src/tools/tests/chrome_mock.py b/native_client_sdk/src/tools/tests/chrome_mock.py
index cd20e88ac1f28e370d3e00aa9518308440178b23..966e2310ad70444284b603d25baf3e565f153421 100755
--- a/native_client_sdk/src/tools/tests/chrome_mock.py
+++ b/native_client_sdk/src/tools/tests/chrome_mock.py
@@ -3,37 +3,39 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import optparse
+"""Mock chrome process used by test code for http server."""
+
+import argparse
import sys
import time
import urllib2
def PrintAndFlush(s):
- print s
+ sys.stdout.write(s + '\n')
sys.stdout.flush()
def main(args):
- parser = optparse.OptionParser(usage='%prog [options] <URL to load>')
- parser.add_option('--post', help='POST to URL.', dest='post',
- action='store_true')
- parser.add_option('--get', help='GET to URL.', dest='get',
- action='store_true')
- parser.add_option('--sleep',
- help='Number of seconds to sleep after reading URL',
- dest='sleep', default=0)
- parser.add_option('--expect-to-be-killed', help='If set, the script will warn'
- ' if it isn\'t killed before it finishes sleeping.',
- dest='expect_to_be_killed', action='store_true')
- options, args = parser.parse_args(args)
- if len(args) != 1:
- parser.error('Expected URL to load.')
+ parser = argparse.ArgumentParser(description=__doc__)
+ parser.add_argument('--post', help='POST to URL.', dest='post',
+ action='store_true')
+ parser.add_argument('--get', help='GET to URL.', dest='get',
+ action='store_true')
+ parser.add_argument('--sleep',
+ help='Number of seconds to sleep after reading URL',
+ dest='sleep', default=0)
+ parser.add_argument('--expect-to-be-killed', help='If set, the script will'
+ ' warn if it isn\'t killed before it finishes sleeping.',
+ dest='expect_to_be_killed', action='store_true')
+ parser.add_argument('url')
+
+ options = parser.parse_args(args)
PrintAndFlush('Starting %s.' % sys.argv[0])
if options.post:
- urllib2.urlopen(args[0], data='').read()
+ urllib2.urlopen(options.url, data='').read()
elif options.get:
- urllib2.urlopen(args[0]).read()
+ urllib2.urlopen(options.url).read()
else:
# Do nothing but wait to be killed.
pass
@@ -42,7 +44,7 @@ def main(args):
if options.expect_to_be_killed:
PrintAndFlush('Done sleeping. Expected to be killed.')
- sys.exit(0)
+ return 0
if __name__ == '__main__':
sys.exit(main(sys.argv[1:]))

Powered by Google App Engine
This is Rietveld 408576698