native_client_sdk/src/test_all.py - Issue 720233003: [NaCl SDK] Convert python scripts from optparse to argparse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/test_all.py

Issue 720233003: [NaCl SDK] Convert python scripts from optparse to argparse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« native_client_sdk/src/doc/doxygen/rst_index.py ('K') | « native_client_sdk/src/doc/doxygen/rst_index.py ('k') | native_client_sdk/src/tools/create_html.py » ('j') | native_client_sdk/src/tools/create_html.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/test_all.py

diff --git a/native_client_sdk/src/test_all.py b/native_client_sdk/src/test_all.py

index 4a451f45a6254c7b9650d02cadee3968d9fa1cd1..54733e09c75222a576d794096944a3b3f3df12b4 100755

--- a/native_client_sdk/src/test_all.py

+++ b/native_client_sdk/src/test_all.py

@@ -54,11 +54,13 @@ TEST_MODULES = [

]

def ExtractToolchains():

- subprocess.check_output([sys.executable, PKG_VER,

- '--packages', ','.join(EXTRACT_PACKAGES),

- '--tar-dir', TAR_DIR,

- '--dest-dir', TOOLCHAIN_OUT,

- 'extract'])

+ cmd = [sys.executable, PKG_VER, '--verbose',

+ '--packages', ','.join(EXTRACT_PACKAGES),

+ '--tar-dir', TAR_DIR,

+ '--dest-dir', TOOLCHAIN_OUT,

+ 'extract']

+ print(cmd)

binji 2014/11/13 23:57:02 why?

Sam Clegg 2014/11/30 17:55:12 Dropped.

+ subprocess.check_output(cmd)

def main():

# Some of the unit tests use parts of toolchains. Extract to TOOLCHAIN_OUT.