Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4494)

Unified Diff: native_client_sdk/src/build_tools/update_sdktools.py

Issue 720233003: [NaCl SDK] Convert python scripts from optparse to argparse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/update_sdktools.py
diff --git a/native_client_sdk/src/build_tools/update_sdktools.py b/native_client_sdk/src/build_tools/update_sdktools.py
index 808aa1bdd6968b6605ed4e79198e559d66e0c928..5e54b314e784d37a5f63ba03e1fd006f4976da52 100755
--- a/native_client_sdk/src/build_tools/update_sdktools.py
+++ b/native_client_sdk/src/build_tools/update_sdktools.py
@@ -19,7 +19,7 @@ any changes. Instead it modifies the manifest file in cloud storage."""
import collections
import difflib
import json
-import optparse
+import argparse
binji 2014/11/13 23:57:02 sort
Sam Clegg 2014/11/30 17:55:11 Done.
import re
import sys
import urllib2
@@ -107,12 +107,10 @@ def UpdateManifestFileToRevision(filename, revision):
def main(args):
- parser = optparse.OptionParser(description=__doc__)
- parser.add_option('-r', '--revision',
+ parser = argparse.ArgumentParser(description=__doc__)
+ parser.add_argument('-r', '--revision',
help='set revision manually, rather than using the latest version')
- options, args = parser.parse_args(args[1:])
- if len(args) != 0:
- parser.error('Unexpected args: %s' % ', '.join(args))
+ options = parser.parse_args(args)
# TODO(binji): http://crbug.com/169047. Rename RealDelegate to something else.
delegate = RealDelegate()
@@ -123,7 +121,8 @@ def main(args):
UpdateManifestFileToRevision('json/naclsdk_manifest0.json', revision)
UpdateManifestFileToRevision('json/naclsdk_manifest2.json', revision)
+ return 0
if __name__ == '__main__':
- sys.exit(main(sys.argv))
+ sys.exit(main(sys.argv[1:]))

Powered by Google App Engine
This is Rietveld 408576698