Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: Source/devtools/front_end/profiler/CPUProfileView.js

Issue 720223002: DevTools: only allow status bar items in status bars. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/CPUProfileView.js
diff --git a/Source/devtools/front_end/profiler/CPUProfileView.js b/Source/devtools/front_end/profiler/CPUProfileView.js
index 45284048dc0e0b8d46d5a9f5202076c5fd78c447..619c3db9962f9d33eddaa5b6feea47e101725b8c 100644
--- a/Source/devtools/front_end/profiler/CPUProfileView.js
+++ b/Source/devtools/front_end/profiler/CPUProfileView.js
@@ -59,22 +59,17 @@ WebInspector.CPUProfileView = function(profileHeader)
var option = options[optionName] || options[WebInspector.CPUProfileView._TypeFlame];
this.viewSelectComboBox.select(option);
- this._statusBarButtonsElement = createElement("span");
-
this.focusButton = new WebInspector.StatusBarButton(WebInspector.UIString("Focus selected function."), "focus-profile-node-status-bar-item");
this.focusButton.setEnabled(false);
this.focusButton.addEventListener("click", this._focusClicked, this);
- this._statusBarButtonsElement.appendChild(this.focusButton.element);
this.excludeButton = new WebInspector.StatusBarButton(WebInspector.UIString("Exclude selected function."), "exclude-profile-node-status-bar-item");
this.excludeButton.setEnabled(false);
this.excludeButton.addEventListener("click", this._excludeClicked, this);
- this._statusBarButtonsElement.appendChild(this.excludeButton.element);
this.resetButton = new WebInspector.StatusBarButton(WebInspector.UIString("Restore all functions."), "reset-profile-status-bar-item");
this.resetButton.setVisible(false);
this.resetButton.addEventListener("click", this._resetClicked, this);
- this._statusBarButtonsElement.appendChild(this.resetButton.element);
this._profileHeader = profileHeader;
this._linkifier = new WebInspector.Linkifier(new WebInspector.Linkifier.DefaultFormatter(30));
@@ -142,9 +137,12 @@ WebInspector.CPUProfileView.prototype = {
this._flameChart.selectRange(timeLeft, timeRight);
},
- get statusBarItems()
+ /**
+ * @return {!Array.<!WebInspector.StatusBarItem>}
+ */
+ statusBarItems: function()
{
- return [this.viewSelectComboBox.element, this._statusBarButtonsElement];
+ return [this.viewSelectComboBox, this.focusButton, this.excludeButton, this.resetButton];
},
/**
@@ -290,7 +288,6 @@ WebInspector.CPUProfileView.prototype = {
switch (this._viewType.get()) {
case WebInspector.CPUProfileView._TypeFlame:
this._ensureFlameChartCreated();
- this._statusBarButtonsElement.classList.toggle("hidden", true);
this._visibleView = this._flameChart;
this._searchableElement = this._flameChart;
break;
@@ -308,7 +305,11 @@ WebInspector.CPUProfileView.prototype = {
break;
}
- this._statusBarButtonsElement.classList.toggle("hidden", this._viewType.get() === WebInspector.CPUProfileView._TypeFlame);
+ var isFlame = this._viewType.get() === WebInspector.CPUProfileView._TypeFlame;
+ this.focusButton.setVisible(!isFlame);
+ this.excludeButton.setVisible(!isFlame);
+ this.resetButton.setVisible(!isFlame);
+
this._visibleView.show(this._searchableView.element);
},
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | Source/devtools/front_end/profiler/CanvasProfileView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698