Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: Source/devtools/front_end/profiler/CanvasReplayStateView.js

Issue 720223002: DevTools: only allow status bar items in status bars. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/CanvasReplayStateView.js
diff --git a/Source/devtools/front_end/profiler/CanvasReplayStateView.js b/Source/devtools/front_end/profiler/CanvasReplayStateView.js
index eb810705b5cbf4a95346567e31471c82bba4bee1..6ef9e2a9a45ded6f3570848723c0a1c1c1938601 100644
--- a/Source/devtools/front_end/profiler/CanvasReplayStateView.js
+++ b/Source/devtools/front_end/profiler/CanvasReplayStateView.js
@@ -40,14 +40,14 @@ WebInspector.CanvasReplayStateView = function(traceLogPlayer)
this.element.classList.add("canvas-replay-state-view");
this._traceLogPlayer = traceLogPlayer;
- var controlsContainer = this.element.createChild("div", "status-bar");
- this._prevButton = this._createControlButton(controlsContainer, "canvas-replay-state-prev", WebInspector.UIString("Previous resource."), this._onResourceNavigationClick.bind(this, false));
- this._nextButton = this._createControlButton(controlsContainer, "canvas-replay-state-next", WebInspector.UIString("Next resource."), this._onResourceNavigationClick.bind(this, true));
- this._createControlButton(controlsContainer, "canvas-replay-state-refresh", WebInspector.UIString("Refresh."), this._onStateRefreshClick.bind(this));
+ var controlsToolbar = new WebInspector.StatusBar(this.element);
+ this._prevButton = this._createControlButton(controlsToolbar, "canvas-replay-state-prev", WebInspector.UIString("Previous resource."), this._onResourceNavigationClick.bind(this, false));
+ this._nextButton = this._createControlButton(controlsToolbar, "canvas-replay-state-next", WebInspector.UIString("Next resource."), this._onResourceNavigationClick.bind(this, true));
+ this._createControlButton(controlsToolbar, "canvas-replay-state-refresh", WebInspector.UIString("Refresh."), this._onStateRefreshClick.bind(this));
this._resourceSelector = new WebInspector.StatusBarComboBox(this._onReplayResourceChanged.bind(this));
this._currentOption = this._resourceSelector.createOption(WebInspector.UIString("<auto>"), WebInspector.UIString("Show state of the last replayed resource."), "");
- controlsContainer.appendChild(this._resourceSelector.element);
+ controlsToolbar.appendStatusBarItem(this._resourceSelector);
/** @type {!Object.<string, string>} */
this._resourceIdToDescription = {};
@@ -102,16 +102,16 @@ WebInspector.CanvasReplayStateView.prototype = {
},
/**
- * @param {!Element} parent
+ * @param {!WebInspector.StatusBar} toolbar
* @param {string} className
* @param {string} title
* @param {function(this:WebInspector.CanvasProfileView)} clickCallback
* @return {!WebInspector.StatusBarButton}
*/
- _createControlButton: function(parent, className, title, clickCallback)
+ _createControlButton: function(toolbar, className, title, clickCallback)
{
var button = new WebInspector.StatusBarButton(title, className + " canvas-replay-button");
- parent.appendChild(button.element);
+ toolbar.appendStatusBarItem(button);
button.makeLongClickEnabled();
button.addEventListener("click", clickCallback, this);

Powered by Google App Engine
This is Rietveld 408576698