Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 720223002: DevTools: only allow status bar items in status bars. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 8affed1417574529f0a3178825a0c1ffc906f321..59d6846fcd951bce6c834b096c0a9e3a457791f7 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -63,7 +63,6 @@ WebInspector.NetworkLogView = function(filterBar, coulmnsVisibilitySetting)
this._currentMatchedRequestIndex = -1;
this._createStatusbarButtons();
- this._createStatusBarItems();
this._linkifier = new WebInspector.Linkifier();
this._allowPopover = true;
@@ -230,18 +229,18 @@ WebInspector.NetworkLogView.prototype = {
},
/**
- * @return {!Array.<!Element>}
+ * @return {!Array.<!WebInspector.StatusBarItem>}
*/
statusBarItems: function()
{
return [
- this._recordButton.element,
- this._clearButton.element,
- this._filterBar.filterButton().element,
- this._largerRequestsButton.element,
- this._preserveLogCheckbox.element,
- this._disableCacheCheckbox.element,
- this._progressBarContainer];
+ this._recordButton,
+ this._clearButton,
+ this._filterBar.filterButton(),
+ this._largerRequestsButton,
+ this._preserveLogCheckbox,
+ this._disableCacheCheckbox,
+ new WebInspector.StatusBarItem(this._progressBarContainer) ];
},
/**
@@ -558,12 +557,6 @@ WebInspector.NetworkLogView.prototype = {
this._dataGrid.markColumnAsSortedBy("timeline", WebInspector.DataGrid.Order.Ascending);
},
- _createStatusBarItems: function()
- {
- this._progressBarContainer = createElement("div");
- this._progressBarContainer.className = "status-bar-item";
- },
-
_updateSummaryBar: function()
{
var requestsNumber = this._nodesByRequestId.size;
@@ -744,6 +737,8 @@ WebInspector.NetworkLogView.prototype = {
this._disableCacheCheckbox = new WebInspector.StatusBarCheckbox(WebInspector.UIString("Disable cache"));
WebInspector.SettingsUI.bindCheckbox(this._disableCacheCheckbox.inputElement, WebInspector.settings.cacheDisabled);
this._disableCacheCheckbox.element.title = WebInspector.UIString("Disable cache (while DevTools is open).");
+
+ this._progressBarContainer = createElement("div");
},
/**
@@ -1918,7 +1913,7 @@ WebInspector.NetworkPanel = function()
WebInspector.Panel.call(this, "network");
this.registerRequiredCSS("network/networkPanel.css");
- this._panelStatusBarElement = this.element.createChild("div", "panel-status-bar");
+ this._panelStatusBar = new WebInspector.StatusBar(this.element);
this._filterBar = new WebInspector.FilterBar();
this._filtersContainer = this.element.createChild("div", "network-filters-header hidden");
this._filtersContainer.appendChild(this._filterBar.filtersElement());
@@ -1965,7 +1960,7 @@ WebInspector.NetworkPanel = function()
var statusBarItems = this._networkLogView.statusBarItems();
for (var i = 0; i < statusBarItems.length; ++i)
- this._panelStatusBarElement.appendChild(statusBarItems[i]);
+ this._panelStatusBar.appendStatusBarItem(statusBarItems[i]);
/**
* @this {WebInspector.NetworkPanel}

Powered by Google App Engine
This is Rietveld 408576698