DevTools: only allow status bar items in status bars.

Source/devtools/front_end/resources/IndexedDBViews.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 47 matching lines @@
 
     this._stringVersionTreeElement = new TreeElement("", null, false);
     this._stringVersionTreeElement.selectable = false;
     this._headersTreeOutline.appendChild(this._stringVersionTreeElement);
 
     this.update(database);
 }
 
 WebInspector.IDBDatabaseView.prototype = {
     /**
+     * @return {!Array.<!WebInspector.StatusBarItem>}
+     */
+    statusBarItems: function()
+    {
+        return [];
+    },
+
+    /**
      * @param {string} name
      * @param {string} value
      */
     _formatHeader: function(name, value)
     {
         var fragment = createDocumentFragment();
         fragment.createChild("div", "attribute-name").textContent = name + ":";
         fragment.createChild("div", "attribute-value source-code").textContent = value;
 
         return fragment;
@@ skipping 122 matching lines @@
 
     /**
      * @return {!Element}
      */
     _createEditorToolbar: function()
     {
         var editorToolbar = createElement("div");
         editorToolbar.classList.add("status-bar");
         editorToolbar.classList.add("data-view-toolbar");
 
-        this._pageBackButton = editorToolbar.createChild("button", "back-button");
-        this._pageBackButton.classList.add("status-bar-item");
-        this._pageBackButton.title = WebInspector.UIString("Show previous page.");
-        this._pageBackButton.disabled = true;
-        this._pageBackButton.appendChild(createElement("img"));
-        this._pageBackButton.addEventListener("click", this._pageBackButtonClicked.bind(this), false);
-        editorToolbar.appendChild(this._pageBackButton);
+        this._pageBackButton = new WebInspector.StatusBarButton(WebInspector.UIString("Show previous page."), "indexed-db-status-bar-back-button");
+        this._pageBackButton.addEventListener("click", this._pageBackButtonClicked, this);
+        editorToolbar.appendChild(this._pageBackButton.element);
 
-        this._pageForwardButton = editorToolbar.createChild("button", "forward-button");
-        this._pageForwardButton.classList.add("status-bar-item");
-        this._pageForwardButton.title = WebInspector.UIString("Show next page.");
-        this._pageForwardButton.disabled = true;
-        this._pageForwardButton.appendChild(createElement("img"));
-        this._pageForwardButton.addEventListener("click", this._pageForwardButtonClicked.bind(this), false);
-        editorToolbar.appendChild(this._pageForwardButton);
+        this._pageForwardButton = new WebInspector.StatusBarButton(WebInspector.UIString("Show next page."), "indexed-db-status-bar-forward-button");
+        this._pageForwardButton.setEnabled(false);
+        this._pageForwardButton.addEventListener("click", this._pageForwardButtonClicked, this);
+        editorToolbar.appendChild(this._pageForwardButton.element);
 
         this._keyInputElement = editorToolbar.createChild("input", "key-input");
         this._keyInputElement.placeholder = WebInspector.UIString("Start from key");
         this._keyInputElement.addEventListener("paste", this._keyInputChanged.bind(this), false);
         this._keyInputElement.addEventListener("cut", this._keyInputChanged.bind(this), false);
         this._keyInputElement.addEventListener("keypress", this._keyInputChanged.bind(this), false);
         this._keyInputElement.addEventListener("keydown", this._keyInputChanged.bind(this), false);
 
         return editorToolbar;
     },
@@ skipping 84 matching lines @@
                 data["number"] = i + skipCount;
                 data["key"] = entries[i].key;
                 data["primaryKey"] = entries[i].primaryKey;
                 data["value"] = entries[i].value;
 
                 var primaryKey = JSON.stringify(this._isIndex ? entries[i].primaryKey : entries[i].key);
                 var node = new WebInspector.IDBDataGridNode(data);
                 this._dataGrid.rootNode().appendChild(node);
             }
 
-            this._pageBackButton.disabled = skipCount === 0;
-            this._pageForwardButton.disabled = !hasMore;
+            this._pageBackButton.setEnabled(!!skipCount);
+            this._pageForwardButton.setEnabled(hasMore);
         }
 
         var idbKeyRange = key ? window.IDBKeyRange.lowerBound(key) : null;
         if (this._isIndex)
             this._model.loadIndexData(this._databaseId, this._objectStore.name, this._index.name, idbKeyRange, skipCount, pageSize, callback.bind(this));
         else
             this._model.loadObjectStoreData(this._databaseId, this._objectStore.name, idbKeyRange, skipCount, pageSize, callback.bind(this));
     },
 
     _refreshButtonClicked: function(event)
     {
         this._updateData(true);
     },
 
     _clearButtonClicked: function(event)
     {
         /**
          * @this {WebInspector.IDBDataView}
          */
         function cleared() {
             this._clearButton.setEnabled(true);
             this._updateData(true);
         }
         this._clearButton.setEnabled(false);
         this._model.clearObjectStore(this._databaseId, this._objectStore.name, cleared.bind(this));
     },
 
-    get statusBarItems()
+    /**
+     * @return {!Array.<!WebInspector.StatusBarItem>}
+     */
+    statusBarItems: function()
     {
-        return [this._refreshButton.element, this._clearButton.element];
+        return [this._refreshButton, this._clearButton];
     },
 
     clear: function()
     {
         this._dataGrid.rootNode().removeChildren();
         this._entries = [];
     },
 
     __proto__: WebInspector.VBox.prototype
 }
@@ skipping 49 matching lines @@
             contents.createTextChildren("\"", value.description, "\"");
             break;
         default:
             contents.classList.add("primitive-value");
             contents.createTextChild(value.description);
         }
     },
 
     __proto__: WebInspector.DataGridNode.prototype
 }