DevTools: only allow status bar items in status bars.

Source/devtools/front_end/profiler/CPUProfileView.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 41 matching lines @@
 
     var options = {};
     options[WebInspector.CPUProfileView._TypeFlame] = this.viewSelectComboBox.createOption(WebInspector.UIString("Chart"), "", WebInspector.CPUProfileView._TypeFlame);
     options[WebInspector.CPUProfileView._TypeHeavy] = this.viewSelectComboBox.createOption(WebInspector.UIString("Heavy (Bottom Up)"), "", WebInspector.CPUProfileView._TypeHeavy);
     options[WebInspector.CPUProfileView._TypeTree] = this.viewSelectComboBox.createOption(WebInspector.UIString("Tree (Top Down)"), "", WebInspector.CPUProfileView._TypeTree);
 
     var optionName = this._viewType.get() || WebInspector.CPUProfileView._TypeFlame;
     var option = options[optionName] || options[WebInspector.CPUProfileView._TypeFlame];
     this.viewSelectComboBox.select(option);
 
-    this._statusBarButtonsElement = createElement("span");
-
     this.focusButton = new WebInspector.StatusBarButton(WebInspector.UIString("Focus selected function."), "focus-profile-node-status-bar-item");
     this.focusButton.setEnabled(false);
     this.focusButton.addEventListener("click", this._focusClicked, this);
-    this._statusBarButtonsElement.appendChild(this.focusButton.element);
 
     this.excludeButton = new WebInspector.StatusBarButton(WebInspector.UIString("Exclude selected function."), "exclude-profile-node-status-bar-item");
     this.excludeButton.setEnabled(false);
     this.excludeButton.addEventListener("click", this._excludeClicked, this);
-    this._statusBarButtonsElement.appendChild(this.excludeButton.element);
 
     this.resetButton = new WebInspector.StatusBarButton(WebInspector.UIString("Restore all functions."), "reset-profile-status-bar-item");
     this.resetButton.setVisible(false);
     this.resetButton.addEventListener("click", this._resetClicked, this);
-    this._statusBarButtonsElement.appendChild(this.resetButton.element);
 
     this._profileHeader = profileHeader;
     this._linkifier = new WebInspector.Linkifier(new WebInspector.Linkifier.DefaultFormatter(30));
 
     this.profile = new WebInspector.CPUProfileDataModel(profileHeader._profile || profileHeader.protocolProfile());
 
     this._changeView();
     if (this._flameChart)
         this._flameChart.update();
 }
@@ skipping 47 matching lines @@
      * @param {!number} timeLeft
      * @param {!number} timeRight
      */
     selectRange: function(timeLeft, timeRight)
     {
         if (!this._flameChart)
             return;
         this._flameChart.selectRange(timeLeft, timeRight);
     },
 
-    get statusBarItems()
+    /**
+     * @return {!Array.<!WebInspector.StatusBarItem>}
+     */
+    statusBarItems: function()
     {
-        return [this.viewSelectComboBox.element, this._statusBarButtonsElement];
+        return [this.viewSelectComboBox, this.focusButton, this.excludeButton, this.resetButton];
     },
 
     /**
      * @return {!WebInspector.ProfileDataGridTree}
      */
     _getBottomUpProfileDataGridTree: function()
     {
         if (!this._bottomUpProfileDataGridTree)
             this._bottomUpProfileDataGridTree = new WebInspector.BottomUpProfileDataGridTree(this, /** @type {!ProfilerAgent.CPUProfileNode} */ (this.profile.profileHead));
         return this._bottomUpProfileDataGridTree;
@@ skipping 125 matching lines @@
 
         this._searchableView.closeSearch();
 
         if (this._visibleView)
             this._visibleView.detach();
 
         this._viewType.set(this.viewSelectComboBox.selectedOption().value);
         switch (this._viewType.get()) {
         case WebInspector.CPUProfileView._TypeFlame:
             this._ensureFlameChartCreated();
-            this._statusBarButtonsElement.classList.toggle("hidden", true);
             this._visibleView = this._flameChart;
             this._searchableElement = this._flameChart;
             break;
         case WebInspector.CPUProfileView._TypeTree:
             this.profileDataGridTree = this._getTopDownProfileDataGridTree();
             this._sortProfile();
             this._visibleView = this.dataGrid;
             this._searchableElement = this.profileDataGridTree;
             break;
         case WebInspector.CPUProfileView._TypeHeavy:
             this.profileDataGridTree = this._getBottomUpProfileDataGridTree();
             this._sortProfile();
             this._visibleView = this.dataGrid;
             this._searchableElement = this.profileDataGridTree;
             break;
         }
 
-        this._statusBarButtonsElement.classList.toggle("hidden", this._viewType.get() === WebInspector.CPUProfileView._TypeFlame);
+        var isFlame = this._viewType.get() === WebInspector.CPUProfileView._TypeFlame;
+        this.focusButton.setVisible(!isFlame);
+        this.excludeButton.setVisible(!isFlame);
+        this.resetButton.setVisible(!isFlame);
+
         this._visibleView.show(this._searchableView.element);
     },
 
     _focusClicked: function(event)
     {
         if (!this.dataGrid.selectedNode)
             return;
 
         this.resetButton.setVisible(true);
         this.profileDataGridTree.focus(this.dataGrid.selectedNode);
@@ skipping 456 matching lines @@
     _notifyTempFileReady: function()
     {
         if (this._onTempFileReady) {
             this._onTempFileReady();
             this._onTempFileReady = null;
         }
     },
 
     __proto__: WebInspector.ProfileHeader.prototype
 }