DevTools: only allow status bar items in status bars.

Source/devtools/front_end/network/NetworkPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 45 matching lines @@
     this._matchedRequestCount = 0;
     this._highlightedSubstringChanges = [];
 
     /** @type {!Array.<!WebInspector.NetworkLogView.Filter>} */
     this._filters = [];
 
     this._currentMatchedRequestNode = null;
     this._currentMatchedRequestIndex = -1;
 
     this._createStatusbarButtons();
-    this._createStatusBarItems();
     this._linkifier = new WebInspector.Linkifier();
 
     this._allowPopover = true;
 
     /** @type {number} */
     this._rowHeight = 0;
 
     this._addFilters();
     this._resetSuggestionBuilder();
     this._initializeView();
@@ skipping 146 matching lines @@
         this._updateRowsSize();
 
         this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));
         // Enable faster hint.
         this._popoverHelper.setTimeout(250, 250);
 
         this.switchViewMode(true);
     },
 
     /**
-     * @return {!Array.<!Element>}
+     * @return {!Array.<!WebInspector.StatusBarItem>}
      */
     statusBarItems: function()
     {
         return [
-            this._recordButton.element,
-            this._clearButton.element,
-            this._filterBar.filterButton().element,
-            this._largerRequestsButton.element,
-            this._preserveLogCheckbox.element,
-            this._disableCacheCheckbox.element,
-            this._progressBarContainer];
+            this._recordButton,
+            this._clearButton,
+            this._filterBar.filterButton(),
+            this._largerRequestsButton,
+            this._preserveLogCheckbox,
+            this._disableCacheCheckbox,
+            new WebInspector.StatusBarItem(this._progressBarContainer) ];
     },
 
     /**
      * @return {boolean}
      */
     usesLargeRows: function()
     {
         return !!WebInspector.settings.resourcesLargeRows.get();
     },
 
@@ skipping 296 matching lines @@
         var selectedOption = this._timelineSortSelector[selectedIndex];
         var value = selectedOption.value;
 
         this._setCalculator(this._calculators[value]);
         var sortingFunction = this._sortingFunctions[value];
         this._dataGrid.sortNodes(sortingFunction);
         this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode), false);
         this._dataGrid.markColumnAsSortedBy("timeline", WebInspector.DataGrid.Order.Ascending);
     },
 
-    _createStatusBarItems: function()
-    {
-        this._progressBarContainer = createElement("div");
-        this._progressBarContainer.className = "status-bar-item";
-    },
-
     _updateSummaryBar: function()
     {
         var requestsNumber = this._nodesByRequestId.size;
 
         if (!requestsNumber) {
             if (this._summaryBarElement._isDisplayingWarning)
                 return;
             this._summaryBarElement._isDisplayingWarning = true;
             this._summaryBarElement.removeChildren();
             this._summaryBarElement.createChild("div", "warning-icon-small");
@@ skipping 150 matching lines @@
         this._largerRequestsButton = new WebInspector.StatusBarButton(WebInspector.UIString("Use small resource rows."), "network-larger-resources-status-bar-item");
         this._largerRequestsButton.setToggled(WebInspector.settings.resourcesLargeRows.get());
         this._largerRequestsButton.addEventListener("click", this._toggleLargerRequests, this);
 
         this._preserveLogCheckbox = new WebInspector.StatusBarCheckbox(WebInspector.UIString("Preserve log"));
         this._preserveLogCheckbox.element.title = WebInspector.UIString("Do not clear log on page reload / navigation.");
 
         this._disableCacheCheckbox = new WebInspector.StatusBarCheckbox(WebInspector.UIString("Disable cache"));
         WebInspector.SettingsUI.bindCheckbox(this._disableCacheCheckbox.inputElement, WebInspector.settings.cacheDisabled);
         this._disableCacheCheckbox.element.title = WebInspector.UIString("Disable cache (while DevTools is open).");
+
+        this._progressBarContainer = createElement("div");
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _loadEventFired: function(event)
     {
         if (!this._recordButton.toggled())
             return;
 
@@ skipping 1154 matching lines @@
  * @constructor
  * @implements {WebInspector.ContextMenu.Provider}
  * @implements {WebInspector.Searchable}
  * @extends {WebInspector.Panel}
  */
 WebInspector.NetworkPanel = function()
 {
     WebInspector.Panel.call(this, "network");
     this.registerRequiredCSS("network/networkPanel.css");
 
-    this._panelStatusBarElement = this.element.createChild("div", "panel-status-bar");
+    this._panelStatusBar = new WebInspector.StatusBar(this.element);
     this._filterBar = new WebInspector.FilterBar();
     this._filtersContainer = this.element.createChild("div", "network-filters-header hidden");
     this._filtersContainer.appendChild(this._filterBar.filtersElement());
     this._filterBar.addEventListener(WebInspector.FilterBar.Events.FiltersToggled, this._onFiltersToggled, this);
     this._filterBar.setName("networkPanel");
 
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.show(this.element);
     var contentsElement = this._searchableView.element;
 
@@ skipping 26 matching lines @@
     this._networkLogView.addEventListener(WebInspector.NetworkLogView.EventTypes.SearchCountUpdated, this._onSearchCountUpdated, this);
     this._networkLogView.addEventListener(WebInspector.NetworkLogView.EventTypes.SearchIndexUpdated, this._onSearchIndexUpdated, this);
 
     this._closeButtonElement = this._viewsContainerElement.createChild("div", "close-button");
     this._closeButtonElement.id = "network-close-button";
     this._closeButtonElement.addEventListener("click", this._toggleGridMode.bind(this), false);
     this._viewsContainerElement.appendChild(this._closeButtonElement);
 
     var statusBarItems = this._networkLogView.statusBarItems();
     for (var i = 0; i < statusBarItems.length; ++i)
-        this._panelStatusBarElement.appendChild(statusBarItems[i]);
+        this._panelStatusBar.appendStatusBarItem(statusBarItems[i]);
 
     /**
      * @this {WebInspector.NetworkPanel}
      * @return {?WebInspector.SourceFrame}
      */
     function sourceFrameGetter()
     {
         return this._networkItemView.currentSourceFrame();
     }
     WebInspector.GoToLineDialog.install(this, sourceFrameGetter.bind(this));
@@ skipping 1333 matching lines @@
             this._writeProgress.done();
             return;
         }
         const chunkSize = 100000;
         var text = this._text.substring(this._bytesWritten, this._bytesWritten + chunkSize);
         this._bytesWritten += text.length;
         stream.write(text, this._writeNextChunk.bind(this));
         this._writeProgress.setWorked(this._bytesWritten);
     }
 }