Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 720223002: DevTools: only allow status bar items in status bars. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 516
517 _onIdsRangeChanged: function(event) 517 _onIdsRangeChanged: function(event)
518 { 518 {
519 var minId = event.data.minId; 519 var minId = event.data.minId;
520 var maxId = event.data.maxId; 520 var maxId = event.data.maxId;
521 this._selectedSizeText.setText(WebInspector.UIString("Selected size: %s" , Number.bytesToString(event.data.size))); 521 this._selectedSizeText.setText(WebInspector.UIString("Selected size: %s" , Number.bytesToString(event.data.size)));
522 if (this._constructorsDataGrid.snapshot) 522 if (this._constructorsDataGrid.snapshot)
523 this._constructorsDataGrid.setSelectionRange(minId, maxId); 523 this._constructorsDataGrid.setSelectionRange(minId, maxId);
524 }, 524 },
525 525
526 get statusBarItems() 526 /**
527 * @return {!Array.<!WebInspector.StatusBarItem>}
528 */
529 statusBarItems: function()
527 { 530 {
528 var result = [this._perspectiveSelect.element, this._classNameFilter.ele ment]; 531 var result = [this._perspectiveSelect, this._classNameFilter];
529 if (this._profile.profileType() !== WebInspector.ProfileTypeRegistry.ins tance.trackingHeapSnapshotProfileType) 532 if (this._profile.profileType() !== WebInspector.ProfileTypeRegistry.ins tance.trackingHeapSnapshotProfileType)
530 result.push(this._baseSelect.element, this._filterSelect.element); 533 result.push(this._baseSelect, this._filterSelect);
531 result.push(this._selectedSizeText.element); 534 result.push(this._selectedSizeText);
532 return result; 535 return result;
533 }, 536 },
534 537
535 wasShown: function() 538 wasShown: function()
536 { 539 {
537 // FIXME: load base and current snapshots in parallel 540 // FIXME: load base and current snapshots in parallel
538 this._profile.load(profileCallback.bind(this)); 541 this._profile.load(profileCallback.bind(this));
539 542
540 /** 543 /**
541 * @this {WebInspector.HeapSnapshotView} 544 * @this {WebInspector.HeapSnapshotView}
(...skipping 1662 matching lines...) Expand 10 before | Expand all | Expand 10 after
2204 name.textContent = frame.functionName; 2207 name.textContent = frame.functionName;
2205 if (frame.scriptId) { 2208 if (frame.scriptId) {
2206 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ; 2209 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ;
2207 frameDiv.appendChild(urlElement); 2210 frameDiv.appendChild(urlElement);
2208 } 2211 }
2209 } 2212 }
2210 }, 2213 },
2211 2214
2212 __proto__: WebInspector.View.prototype 2215 __proto__: WebInspector.View.prototype
2213 } 2216 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698