DevTools: only allow status bar items in status bars.

Source/devtools/front_end/extensions/ExtensionPanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
  * @param {!WebInspector.ExtensionServer} server
  * @param {string} id
  * @param {string} pageURL
  */
 WebInspector.ExtensionPanel = function(server, id, pageURL)
 {
     WebInspector.Panel.call(this, id);
     this._server = server;
     this.setHideOnDetach();
     this.element.classList.add("extension-panel");
-    this._panelStatusBarElement = this.element.createChild("div", "panel-status-bar hidden");
+    this._panelStatusBar = new WebInspector.StatusBar(this.element);
+    this._panelStatusBar.element.classList.add("hidden");
 
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.show(this.element);
 
     var extensionView = new WebInspector.ExtensionView(server, id, pageURL, "extension");
     extensionView.show(this._searchableView.element);
     this.setDefaultFocusedElement(extensionView.defaultFocusedElement());
 }
 
 WebInspector.ExtensionPanel.prototype = {
     /**
      * @return {!Element}
      */
     defaultFocusedElement: function()
     {
         return WebInspector.View.prototype.defaultFocusedElement.call(this);
     },
 
     /**
-     * @param {!Element} element
+     * @param {!WebInspector.StatusBarItem} item
      */
-    addStatusBarItem: function(element)
+    addStatusBarItem: function(item)
     {
-        this._panelStatusBarElement.classList.remove("hidden");
-        this._panelStatusBarElement.appendChild(element);
+        this._panelStatusBar.element.classList.remove("hidden");
+        this._panelStatusBar.appendStatusBarItem(item);

[apavlov, 2014/11/14 09:36:07]

Could be just "append", since we don't have any other types to append.

[pfeldman, 2014/11/14 09:37:18]

I'm planning to rename the whole thing.

     },
 
     searchCanceled: function()
     {
         this._server.notifySearchAction(this.name, WebInspector.extensionAPI.panels.SearchAction.CancelSearch);
         this._searchableView.updateSearchMatchesCount(0);
     },
 
     /**
      * @return {!WebInspector.SearchableView}
@@ skipping 47 matching lines @@
  * @constructor
  * @param {!WebInspector.ExtensionServer} server
  * @param {string} id
  * @param {string} iconURL
  * @param {string=} tooltip
  * @param {boolean=} disabled
  */
 WebInspector.ExtensionButton = function(server, id, iconURL, tooltip, disabled)
 {
     this._id = id;
-    this.element = createElement("button");
-    this.element.className = "status-bar-item extension";
-    this.element.addEventListener("click", server.notifyButtonClicked.bind(server, this._id), false);
+
+    this._statusBarButton = new WebInspector.StatusBarButton("", "extension");
+    this._statusBarButton.addEventListener("click", server.notifyButtonClicked.bind(server, this._id));
     this.update(iconURL, tooltip, disabled);
 }
 
 WebInspector.ExtensionButton.prototype = {
     /**
      * @param {string} iconURL
      * @param {string=} tooltip
      * @param {boolean=} disabled
      */
     update: function(iconURL, tooltip, disabled)
     {
         if (typeof iconURL === "string")
-            this.element.style.backgroundImage = "url(" + iconURL + ")";
+            this._statusBarButton.setBackgroundImage(iconURL);
         if (typeof tooltip === "string")
-            this.element.title = tooltip;
+            this._statusBarButton.setTitle(tooltip);
         if (typeof disabled === "boolean")
-            this.element.disabled = disabled;
+            this._statusBarButton.setEnabled(!disabled);
+    },
+
+    /**
+     * @return {!WebInspector.StatusBarButton}
+     */
+    statusBarButton: function()
+    {
+        return this._statusBarButton;
     }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SidebarPane}
  * @param {!WebInspector.ExtensionServer} server
  * @param {string} panelName
  * @param {string} title
  * @param {string} id
@@ skipping 119 matching lines @@
         if (!title)
             section.headerElement.classList.add("hidden");
         section.expanded = true;
         section.editable = false;
         this._objectPropertiesView.element.appendChild(section.element);
         callback();
     },
 
     __proto__: WebInspector.SidebarPane.prototype
 }