Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 720203002: Rename HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP (Closed)

Created:
6 years, 1 month ago by zhaoze.zhou
Modified:
6 years, 1 month ago
Reviewers:
pdr., rwlbuis
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP Because this build time flag is only used for debugging purpose, rename it to DEBUG_TEXT_AUTOSIZING_ON_DESKTOP. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185335

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M LayoutTests/fast/text-autosizing/resources/autosizingTest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Settings.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhaoze.zhou
pdr@chromium.org: Please take a look. As I see, this build-time flag never been defined(maybe someone ...
6 years, 1 month ago (2014-11-13 15:54:50 UTC) #2
pdr.
On 2014/11/13 at 15:54:50, zhaoze.zhou wrote: > pdr@chromium.org: Please take a look. As I see, ...
6 years, 1 month ago (2014-11-13 18:33:20 UTC) #3
zhaoze.zhou
On 2014/11/13 18:33:20, pdr wrote: > On 2014/11/13 at 15:54:50, zhaoze.zhou wrote: > > mailto:pdr@chromium.org: ...
6 years, 1 month ago (2014-11-13 19:34:51 UTC) #5
pdr.
lgtm
6 years, 1 month ago (2014-11-14 00:33:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720203002/40001
6 years, 1 month ago (2014-11-14 00:33:58 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 00:36:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 185335

Powered by Google App Engine
This is Rietveld 408576698