Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

Issue 720163003: Safe Browsing: Add Omnibox Interaction Incident Reporter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
index 30e5beb801cd139b7fad3f114dcead603725e136..9bf27c09e691e9b29c0aa21994d2102e6a61a392 100644
--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
@@ -28,6 +28,7 @@
#include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_handlers.h"
#include "chrome/browser/safe_browsing/incident_reporting/environment_data_collection.h"
#include "chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h"
+#include "chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handlers.h"
#include "chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h"
#include "chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_handlers.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
@@ -49,8 +50,9 @@ enum IncidentType {
TRACKED_PREFERENCE = 1,
BINARY_INTEGRITY = 2,
BLACKLIST_LOAD = 3,
+ OMNIBOX_INTERACTION = 4,
// Values for new incident types go here.
- NUM_INCIDENT_TYPES = 4
+ NUM_INCIDENT_TYPES = 5
};
// The action taken for an incident; used for user metrics (see
@@ -89,6 +91,8 @@ size_t CountIncidents(const ClientIncidentReport_IncidentData& incident) {
++result;
if (incident.has_blacklist_load())
++result;
+ if (incident.has_omnibox_interaction())
+ ++result;
// Add detection for new incident types here.
return result;
}
@@ -102,9 +106,11 @@ IncidentType GetIncidentType(
return BINARY_INTEGRITY;
if (incident_data.has_blacklist_load())
return BLACKLIST_LOAD;
+ if (incident_data.has_omnibox_interaction())
+ return OMNIBOX_INTERACTION;
// Add detection for new incident types here.
- COMPILE_ASSERT(BLACKLIST_LOAD + 1 == NUM_INCIDENT_TYPES,
+ COMPILE_ASSERT(OMNIBOX_INTERACTION + 1 == NUM_INCIDENT_TYPES,
add_support_for_new_types);
NOTREACHED();
return NUM_INCIDENT_TYPES;
@@ -141,9 +147,13 @@ PersistentIncidentState ComputeIncidentState(
state.key = GetBlacklistLoadIncidentKey(incident);
state.digest = GetBlacklistLoadIncidentDigest(incident);
break;
+ case OMNIBOX_INTERACTION:
+ state.key = GetOmniboxIncidentKey(incident);
+ state.digest = GetOmniboxIncidentDigest(incident);
+ break;
// Add handling for new incident types here.
default:
- COMPILE_ASSERT(BLACKLIST_LOAD + 1 == NUM_INCIDENT_TYPES,
+ COMPILE_ASSERT(OMNIBOX_INTERACTION + 1 == NUM_INCIDENT_TYPES,
add_support_for_new_types);
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698