Safe Browsing: Add Omnibox Interaction Incident Reporter

chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handlers.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handlers.h"
+
+#include "base/logging.h"
+#include "chrome/browser/safe_browsing/incident_reporting/incident_handler_util.h"

[grt (UTC plus 2), 2014/12/05 18:40:56]

unused

[Mark P, 2014/12/09 19:23:30]

Done.

+#include "chrome/common/safe_browsing/csd.pb.h"
+
+namespace safe_browsing {
+
+std::string GetOmniboxIncidentKey(
+    const ClientIncidentReport_IncidentData& incident_data) {
+  DCHECK(incident_data.has_omnibox_interaction());
+  // We want to only return the first suspicious omnibox interaction so we use

[grt (UTC plus 2), 2014/12/05 18:40:56]

There's been some discussion on chromium-dev about using "we" like this
(https://groups.google.com/a/chromium.org/d/topic/chromium-dev/NH-S6KCkr2M/dis...).
I think this and other comments could be made a bit more precise without the
pronoun and discussing desires ("we want..."). For example:
  // Return a constant, as only one kind of suspicious interaction is detected.

[Mark P, 2014/12/09 19:23:30]

Thanks for the improved comment.  The original comment was icky mostly because I
didn't clearly understand (or need to understand) what key and digest meant.

+  // a constant key so all later reports will be duped against this one.
+  return std::string("1");
+}
+
+uint32_t GetOmniboxIncidentDigest(
+    const ClientIncidentReport_IncidentData& incident_data) {
+  DCHECK(incident_data.has_omnibox_interaction());
+  // We use a constant digest because don't need to report additional

[grt (UTC plus 2), 2014/12/05 18:40:56]

  // Return a constant (independent of the incident's payload) so that only the
  // first suspicious interaction is reported.

[Mark P, 2014/12/09 19:23:29]

Done.

+  // information.
+  return 1u;
+}
+
+}  // namespace safe_browsing