Issue 7201026: Print suppression hashes for TSan reports

Issue 7201026: Print suppression hashes for TSan reports (Closed)

Created:
9 years, 6 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko, jochen (gone - plz use gerrit)

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Print suppression hashes for TSan reports The buildbot should extract the suppression snippets, all the needed regexps are already there for Valgrind and HeapChecker bots. Also, make Memcheck hashes device-independent TEST=Run base_unittests --gtest_filter=*Sanity* without suppressions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89804

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	tools/valgrind/memcheck_analyze.py	View	1 2 3	4 chunks	+12 lines, -3 lines	0 comments	Download
	M	tools/valgrind/tsan_analyze.py	View	1 2 3 4	2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Hi Alexander, Jochen, Can you please review this small patch? Thanks, Timur

9 years, 6 months ago (2011-06-20 14:19:26 UTC) #1

Alexander Potapenko

LGTM http://codereview.chromium.org/7201026/diff/4001/tools/valgrind/memcheck_analyze.py File tools/valgrind/memcheck_analyze.py (right): http://codereview.chromium.org/7201026/diff/4001/tools/valgrind/memcheck_analyze.py#newcode13 tools/valgrind/memcheck_analyze.py:13: import hashlib Please fix the import order

9 years, 6 months ago (2011-06-20 14:57:04 UTC) #4

Timur Iskhodzhanov

9 years, 6 months ago (2011-06-20 15:04:51 UTC) #5

Jochen?

http://codereview.chromium.org/7201026/diff/4001/tools/valgrind/memcheck_anal...
File tools/valgrind/memcheck_analyze.py (right):

http://codereview.chromium.org/7201026/diff/4001/tools/valgrind/memcheck_anal...
tools/valgrind/memcheck_analyze.py:13: import hashlib
On 2011/06/20 14:57:04, Alexander Potapenko wrote:
> Please fix the import order

Done.

Expand Messages | Collapse Messages