Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 720033004: Correct accounting for wrapped resources (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@res2
Project:
skia
Visibility:
Public.

Description

Correct accounting for wrapped resources BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/dace19ec17e85872df3fb35212e1b8bce72018b6

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : add test #

Patch Set 4 : rebase on top of changes to parent CL #

Patch Set 5 : update comment #

Patch Set 6 : rebase #

Patch Set 7 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -20 lines) Patch
M src/gpu/GrContext.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 1 2 3 4 5 3 chunks +20 lines, -4 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 1 2 3 4 5 6 12 chunks +71 lines, -14 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 5 3 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
Follow up to https://codereview.chromium.org/716143004/
6 years, 1 month ago (2014-11-13 14:34:31 UTC) #2
robertphillips
lgtm
6 years, 1 month ago (2014-11-13 17:09:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720033004/120001
6 years, 1 month ago (2014-11-14 22:24:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/987)
6 years, 1 month ago (2014-11-14 22:29:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720033004/120001
6 years, 1 month ago (2014-11-17 15:22:14 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 15:34:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/dace19ec17e85872df3fb35212e1b8bce72018b6

Powered by Google App Engine
This is Rietveld 408576698