Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7200045: Move app/mac/ files to ui/gfx/mac/ directory. (Closed)

Created:
9 years, 6 months ago by tfarina
Modified:
9 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move app/mac/ files to ui/gfx/mac/ directory. BUG=72317 TEST=None R=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89956

Patch Set 1 #

Total comments: 10

Patch Set 2 : rsesek review #

Total comments: 4

Patch Set 3 : remove unneeded includes #

Total comments: 4

Patch Set 4 : remove more unused includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -227 lines) Patch
M app/app_base.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D app/mac/nsimage_cache.h View 1 chunk +0 lines, -35 lines 0 comments Download
D app/mac/nsimage_cache.mm View 1 chunk +0 lines, -75 lines 0 comments Download
D app/mac/nsimage_cache_unittest.cc.README View 1 chunk +0 lines, -3 lines 0 comments Download
D app/mac/scoped_nsdisable_screen_updates.h View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/nsimage_cache_unittest.mm View 1 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/web_contents_drag_source.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/web_drag_source.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button.mm View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + ui/gfx/mac/nsimage_cache.h View 1 3 chunks +6 lines, -8 lines 0 comments Download
A + ui/gfx/mac/nsimage_cache.mm View 1 3 chunks +4 lines, -6 lines 0 comments Download
A + ui/gfx/mac/nsimage_cache_unittest.cc.README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/mac/scoped_ns_disable_screen_updates.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M ui/ui_gfx.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webcursor_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
9 years, 6 months ago (2011-06-20 23:29:44 UTC) #1
Robert Sesek
http://codereview.chromium.org/7200045/diff/1/ui/gfx/mac/nsimage_cache.h File ui/gfx/mac/nsimage_cache.h (right): http://codereview.chromium.org/7200045/diff/1/ui/gfx/mac/nsimage_cache.h#newcode17 ui/gfx/mac/nsimage_cache.h:17: namespace app { This should be switched to the ...
9 years, 6 months ago (2011-06-21 14:08:13 UTC) #2
tfarina
http://codereview.chromium.org/7200045/diff/1/ui/gfx/mac/nsimage_cache.h File ui/gfx/mac/nsimage_cache.h (right): http://codereview.chromium.org/7200045/diff/1/ui/gfx/mac/nsimage_cache.h#newcode17 ui/gfx/mac/nsimage_cache.h:17: namespace app { On 2011/06/21 14:08:13, rsesek wrote: > ...
9 years, 6 months ago (2011-06-21 18:35:13 UTC) #3
Robert Sesek
http://codereview.chromium.org/7200045/diff/4002/chrome/browser/ui/cocoa/toolbar/reload_button.mm File chrome/browser/ui/cocoa/toolbar/reload_button.mm (right): http://codereview.chromium.org/7200045/diff/4002/chrome/browser/ui/cocoa/toolbar/reload_button.mm#newcode15 chrome/browser/ui/cocoa/toolbar/reload_button.mm:15: #include "ui/gfx/mac/nsimage_cache.h" Is this needed? http://codereview.chromium.org/7200045/diff/4002/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right): ...
9 years, 6 months ago (2011-06-21 20:13:28 UTC) #4
tfarina
http://codereview.chromium.org/7200045/diff/4002/chrome/browser/ui/cocoa/toolbar/reload_button.mm File chrome/browser/ui/cocoa/toolbar/reload_button.mm (right): http://codereview.chromium.org/7200045/diff/4002/chrome/browser/ui/cocoa/toolbar/reload_button.mm#newcode15 chrome/browser/ui/cocoa/toolbar/reload_button.mm:15: #include "ui/gfx/mac/nsimage_cache.h" On 2011/06/21 20:13:28, rsesek wrote: > Is ...
9 years, 6 months ago (2011-06-21 20:23:36 UTC) #5
Robert Sesek
LGTM pending trybots and nits http://codereview.chromium.org/7200045/diff/5004/chrome/browser/ui/cocoa/hung_renderer_controller.mm File chrome/browser/ui/cocoa/hung_renderer_controller.mm (right): http://codereview.chromium.org/7200045/diff/5004/chrome/browser/ui/cocoa/hung_renderer_controller.mm#newcode32 chrome/browser/ui/cocoa/hung_renderer_controller.mm:32: #include "ui/gfx/mac/nsimage_cache.h" Unused here. ...
9 years, 6 months ago (2011-06-21 21:24:00 UTC) #6
tfarina
9 years, 6 months ago (2011-06-21 23:01:33 UTC) #7 
http://codereview.chromium.org/7200045/diff/5004/chrome/browser/ui/cocoa/hung...
File chrome/browser/ui/cocoa/hung_renderer_controller.mm (right):

http://codereview.chromium.org/7200045/diff/5004/chrome/browser/ui/cocoa/hung...
chrome/browser/ui/cocoa/hung_renderer_controller.mm:32: #include
"ui/gfx/mac/nsimage_cache.h"
On 2011/06/21 21:24:00, rsesek wrote:
> Unused here.

Removed.

http://codereview.chromium.org/7200045/diff/5004/chrome/browser/ui/cocoa/tabp...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/7200045/diff/5004/chrome/browser/ui/cocoa/tabp...
chrome/browser/ui/cocoa/tabpose_window.mm:41: #include
"ui/gfx/mac/nsimage_cache.h"
On 2011/06/21 21:24:00, rsesek wrote:
> Used?

Removed.

Powered by Google App Engine
This is Rietveld 408576698