Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 720003002: Fixed positioned element with relative percentage positioned parent is wrongly placed (Closed)

Created:
6 years, 1 month ago by Manuel Rego
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fixed positioned element with relative percentage positioned parent is wrongly placed The usage of Length::value() is causing a bug as 25% was translated to 25px, which is wrong. Use valueForLength() instead in order to get the accurate value. Modified current test to add some examples using percentages. BUG=31286, 425991 TEST=fast/css/css-properties-position-relative-as-parent-fixed.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M LayoutTests/fast/css/css-properties-position-relative-as-parent-fixed.html View 1 chunk +26 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/css-properties-position-relative-as-parent-fixed-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/Length.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Manuel Rego
6 years, 1 month ago (2014-11-12 23:20:47 UTC) #2
leviw_travelin_and_unemployed
LGTM. Gross...
6 years, 1 month ago (2014-11-12 23:29:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720003002/1
6 years, 1 month ago (2014-11-13 06:08:34 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 07:20:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185274

Powered by Google App Engine
This is Rietveld 408576698