Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 719993002: Remove CSSValue::Type and CSSValue::cssValueType() (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rwlbuis, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove CSSValue::Type and CSSValue::cssValueType() This interface isn't particularly useful and since we no longer expose it to the web we don't need to keep it around. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -50 lines) Patch
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 1 chunk +12 lines, -20 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Timothy Loh
6 years, 1 month ago (2014-11-12 22:08:53 UTC) #2
dstockwell
lgtm
6 years, 1 month ago (2014-11-12 22:17:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719993002/1
6 years, 1 month ago (2014-11-12 22:18:04 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 23:19:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185253

Powered by Google App Engine
This is Rietveld 408576698