Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: remoting/host/heartbeat_sender_unittest.cc

Issue 719983002: Reporting of policy errors via host-offline-reason: part 3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hor-nohoststatussender
Patch Set: Trying to see how things look without mock_callback.h Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/heartbeat_sender_unittest.cc
diff --git a/remoting/host/heartbeat_sender_unittest.cc b/remoting/host/heartbeat_sender_unittest.cc
index 4a6888c08c03745a147b4bc642cc146fa333db58..9da9dee17ae150db6be5a8bbcd4c1b5a6c2bf5b4 100644
--- a/remoting/host/heartbeat_sender_unittest.cc
+++ b/remoting/host/heartbeat_sender_unittest.cc
@@ -14,7 +14,6 @@
#include "remoting/base/constants.h"
#include "remoting/base/rsa_key_pair.h"
#include "remoting/base/test_rsa_key_pair.h"
-#include "remoting/host/mock_callback.h"
#include "remoting/signaling/iq_sender.h"
#include "remoting/signaling/mock_signal_strategy.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -53,6 +52,11 @@ ACTION_P(RemoveListener, list) {
list->erase(arg0);
}
+class MockClosure {
+ public:
+ MOCK_CONST_METHOD0(Run, void());
+};
+
class HeartbeatSenderTest
: public testing::Test {
protected:
@@ -72,8 +76,10 @@ class HeartbeatSenderTest
.Times(0);
heartbeat_sender_.reset(new HeartbeatSender(
- mock_heartbeat_successful_callback_.GetCallback(),
- mock_unknown_host_id_error_callback_.GetCallback(),
+ base::Bind(&MockClosure::Run,
+ base::Unretained(&mock_heartbeat_successful_callback_)),
+ base::Bind(&MockClosure::Run,
+ base::Unretained(&mock_unknown_host_id_error_callback_)),
kHostId, &signal_strategy_, key_pair_, kTestBotJid));
}
@@ -291,7 +297,7 @@ TEST_F(HeartbeatSenderTest, ProcessHostOfflineResponses) {
heartbeat_sender_->SetHostOfflineReason(
"test_error",
- mock_ack_callback.GetCallback());
+ base::Bind(&MockClosure::Run, base::Unretained(&mock_ack_callback)));
heartbeat_sender_->OnSignalStrategyStateChange(SignalStrategy::CONNECTED);
base::RunLoop().RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698