Reporting of policy errors via host-offline-reason: part 3

remoting/host/signaling_connector.h

Index: remoting/host/signaling_connector.h
diff --git a/remoting/host/signaling_connector.h b/remoting/host/signaling_connector.h
index feba6cfe6b5d93a0db9759e691eb5bb40d209e56..acb69218c19afd49df16ae1a2a5e48ec9f0f7327 100644
--- a/remoting/host/signaling_connector.h
+++ b/remoting/host/signaling_connector.h
@@ -39,8 +39,7 @@ class SignalingConnector
 
   // May be called immediately after the constructor to enable OAuth
   // access token updating.
-  // |oauth_token_getter| must outlive SignalingConnector.
-  void EnableOAuth(OAuthTokenGetter* oauth_token_getter);
+  void EnableOAuth(scoped_ptr<OAuthTokenGetter> oauth_token_getter);
 
   // OAuthTokenGetter callback.
   void OnAccessToken(OAuthTokenGetter::Status status,
@@ -69,7 +68,7 @@ class SignalingConnector
   base::Closure auth_failed_callback_;
   scoped_ptr<DnsBlackholeChecker> dns_blackhole_checker_;
 
-  OAuthTokenGetter* oauth_token_getter_;
+  scoped_ptr<OAuthTokenGetter> oauth_token_getter_;

[Lambros, 2014/12/02 03:35:23]

Is this change relevant to this CL?

[Łukasz Anforowicz, 2014/12/02 20:08:01]

Not directly relevant, but please read on.

Assumption1: scoped_ptr is better than raw pointer
Assumption2: we should avoid raw pointers in new code

If I kept the old code in signaling_connector, then I would have to have a raw
pointer (or rather call scoped_ptr<T>.get()) in implementation of
MinimumHeartbeatSupporter::Create.

Assumption3: hygiene is good
Assumption4: small refactorings won't happen if they require an overhead of a
separate changelist

Are these valid?

 
   // Number of times we tried to connect without success.
   int reconnect_attempts_;