Reporting of policy errors via host-offline-reason: part 3

remoting/host/host_signaling_manager.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/host_signaling_manager.h"
+
+#include "base/bind.h"
+#include "base/time/time.h"
+#include "net/base/network_change_notifier.h"
+#include "net/socket/client_socket_factory.h"
+#include "remoting/base/auto_thread_task_runner.h"
+#include "remoting/base/logging.h"
+#include "remoting/base/url_request_context_getter.h"
+#include "remoting/host/chromoting_host_context.h"
+#include "remoting/host/dns_blackhole_checker.h"
+#include "remoting/host/heartbeat_sender.h"
+#include "remoting/host/signaling_connector.h"
+#include "remoting/signaling/xmpp_signal_strategy.h"
+
+namespace remoting {
+
+HostSignalingManager::HostSignalingManager(
+    const scoped_refptr<AutoThreadTaskRunner>& network_task_runner,
+    scoped_ptr<net::NetworkChangeNotifier> network_change_notifier,
+    scoped_ptr<SignalStrategy> signal_strategy,
+    scoped_ptr<SignalingConnector> signaling_connector,
+    scoped_ptr<HeartbeatSender> heartbeat_sender)
+    : network_task_runner_(network_task_runner),
+      network_change_notifier_(network_change_notifier.Pass()),
+      signal_strategy_(signal_strategy.Pass()),
+      signaling_connector_(signaling_connector.Pass()),
+      heartbeat_sender_(heartbeat_sender.Pass()) {
+}
+
+scoped_ptr<HostSignalingManager> HostSignalingManager::Create(
+    const base::Closure& on_heartbeat_successful_callback,
+    const base::Closure& on_unknown_host_id_error_callback,
+    const base::Closure& on_auth_failed_callback,
+    const scoped_refptr<AutoThreadTaskRunner>& network_task_runner,
+    const scoped_refptr<net::URLRequestContextGetter>&
+        url_request_context_getter,
+    const XmppSignalStrategy::XmppServerConfig& xmpp_server_config,
+    const std::string& talkgadget_prefix_policy,
+    const std::string& host_id,
+    const scoped_refptr<const RsaKeyPair>& host_key_pair,
+    const std::string& directory_bot_jid,
+    scoped_ptr<OAuthTokenGetter::OAuthCredentials> oauth_credentials) {
+  DCHECK(network_task_runner->BelongsToCurrentThread());
+
+  scoped_ptr<net::NetworkChangeNotifier> network_change_notifier(
+      net::NetworkChangeNotifier::Create());
+
+  scoped_ptr<XmppSignalStrategy> signal_strategy(
+      new XmppSignalStrategy(net::ClientSocketFactory::GetDefaultFactory(),
+                             url_request_context_getter, xmpp_server_config));
+
+  scoped_ptr<DnsBlackholeChecker> dns_blackhole_checker(new DnsBlackholeChecker(
+      url_request_context_getter, talkgadget_prefix_policy));
+
+  scoped_ptr<SignalingConnector> signaling_connector(new SignalingConnector(
+      signal_strategy.get(), dns_blackhole_checker.Pass(),
+      on_auth_failed_callback));
+
+  if (!oauth_credentials->refresh_token.empty()) {
+    scoped_ptr<OAuthTokenGetter> oauth_token_getter(new OAuthTokenGetter(
+        oauth_credentials.Pass(), url_request_context_getter, false));
+
+    signaling_connector->EnableOAuth(oauth_token_getter.Pass());
+  }
+
+  scoped_ptr<HeartbeatSender> heartbeat_sender(new HeartbeatSender(
+      on_heartbeat_successful_callback, on_unknown_host_id_error_callback,
+      host_id, signal_strategy.get(), host_key_pair, directory_bot_jid));
+
+  return scoped_ptr<HostSignalingManager>(new HostSignalingManager(
+      network_task_runner, network_change_notifier.Pass(),
+      signal_strategy.Pass(), signaling_connector.Pass(),
+      heartbeat_sender.Pass()));
+}
+
+HostSignalingManager::~HostSignalingManager() {
+  DCHECK(network_task_runner_->BelongsToCurrentThread());
+}
+
+void HostSignalingManager::SendHostOfflineReasonAndDelete(
+    const std::string& host_offline_reason,
+    const base::TimeDelta& timeout) {
+  DCHECK(network_task_runner_->BelongsToCurrentThread());
+
+  HOST_LOG << "SendHostOfflineReason: trying to send " << host_offline_reason
+           << " to the bot";

[Wez, 2015/01/09 02:55:45]

nit: No need for "to the bot" - it adds nothing.

Similarly, "trying to send" -> "sending".

[Łukasz Anforowicz, 2015/01/09 19:00:13]

Done.

+
+  heartbeat_sender_->SetHostOfflineReason(
+      host_offline_reason, timeout,
+      base::Bind(&HostSignalingManager::OnHostOfflineReasonAck,
+                 base::Unretained(this)));
+}
+
+void HostSignalingManager::OnHostOfflineReasonAck(bool success) {
+  DCHECK(network_task_runner_->BelongsToCurrentThread());
+  if (success) {
+    HOST_LOG << "SendHostOfflineReason: got ack";

[Wez, 2015/01/09 02:55:45]

got ack -> succeeded

[Łukasz Anforowicz, 2015/01/09 19:00:13]

Done.

+  } else {
+    HOST_LOG << "SendHostOfflineReason: timed out";
+  }
+
+  delete this;
+}
+
+}  // namespace remoting