Issue 719933004: Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 719933004: Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (Closed)

Created:
6 years, 1 month ago by eroman

Modified:
6 years, 1 month ago

Reviewers:
jsbell

CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (WebIDL's "unsigned long" is a 32-bit type) BUG=267360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185260

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/modules/indexeddb/IDBCursor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/modules/indexeddb/IDBCursor.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

eroman

Reviving old change, split out from: https://codereview.chromium.org/21735005/. I spoke with haraken about whether these should ...

6 years, 1 month ago (2014-11-12 23:48:51 UTC) #2

jsbell

lgtm (I think we should switch everything over to xxx_t but that's not this CL!)

6 years, 1 month ago (2014-11-12 23:50:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719933004/20001

6 years, 1 month ago (2014-11-13 00:39:08 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-13 01:55:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 185260