Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: Source/devtools/protocol.json

Issue 719853003: Add source line info for JS Profiler ticks to debug protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index be75e96c83b0001afbe507a950ffad5e256d16f8..7f0e98b2f04e67ac34dc16d1f5c2076c7596c2c8 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -3639,7 +3639,8 @@
{ "name": "callUID", "type": "number", "description": "Call UID." },
{ "name": "children", "type": "array", "items": { "$ref": "CPUProfileNode" }, "description": "Child nodes." },
{ "name": "deoptReason", "type": "string", "description": "The reason of being not optimized. The function may be deoptimized or marked as don't optimize."},
- { "name": "id", "type": "integer", "description": "Unique id of the node." }
+ { "name": "id", "type": "integer", "description": "Unique id of the node." },
+ { "name": "lineTicks", "type": "array", "items": { "$ref": "LineTick" }, "description": "A set of source line ticks." }
apavlov 2014/11/13 09:08:31 "An array", to be precise
Pan 2014/11/17 01:14:22 Done.
]
},
{
@@ -3653,6 +3654,15 @@
{ "name": "samples", "optional": true, "type": "array", "items": { "type": "integer" }, "description": "Ids of samples top nodes." },
{ "name": "timestamps", "optional": true, "type": "array", "items": { "type": "number" }, "description": "Timestamps of the samples in microseconds." }
]
+ },
+ {
+ "id": "LineTick",
apavlov 2014/11/13 09:08:30 LineTickInfo? It is weird for a "LineTick" object
Pan 2014/11/17 01:14:22 Done.
+ "type": "object",
+ "description": "Specifies a number of samples attributed to a certain source line.",
+ "properties": [
+ { "name": "line", "type": "integer", "description": "Source line number." },
apavlov 2014/11/13 09:08:31 The description should specify whether the line nu
Pan 2014/11/17 01:14:22 Done.
+ { "name": "ticks", "type": "integer", "description": "Number of samples attributed to a source line number." }
apavlov 2014/11/13 09:08:30 "Number of samples attributed to the source line."
Pan 2014/11/17 01:14:22 Done.
+ ]
}
],
"commands": [
« Source/core/inspector/ScriptProfile.cpp ('K') | « Source/core/inspector/ScriptProfile.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698