Add source line info for JS Profiler ticks to debug protocol.

Source/core/inspector/ScriptProfile.cpp

 /*
  * Copyright (c) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 46 matching lines @@
 double ScriptProfile::startTime() const
 {
     return static_cast<double>(m_profile->GetStartTime()) / 1000000;
 }
 
 double ScriptProfile::endTime() const
 {
     return static_cast<double>(m_profile->GetEndTime()) / 1000000;
 }
 
+static RefPtr<TypeBuilder::Array<TypeBuilder::Profiler::LineTick> > buildInspectorObjectForLineTicks(const v8::CpuProfileNode* node)
+{
+    RefPtr<TypeBuilder::Array<TypeBuilder::Profiler::LineTick> > array = TypeBuilder::Array<TypeBuilder::Profiler::LineTick>::create();
+    unsigned lineCount = node->GetHitLineCount();
+    if (lineCount) {

[apavlov, 2014/11/13 09:08:30]

We prefer early bail-outs (this saves indentation and helps the readability):

if (!lineCount)
    return array;

[Pan, 2014/11/17 01:14:22]

Done.

+        Vector<v8::CpuProfileNode::LineTick> entries(lineCount);
+        bool res = node->GetLineTicks(&entries[0], lineCount);

[apavlov, 2014/11/13 09:08:30]

This can be inlined into the conditional.

[Pan, 2014/11/17 01:14:22]

Done.

+        if (res) {
+            for (unsigned i = 0; i < lineCount; i++) {
+                RefPtr<TypeBuilder::Profiler::LineTick> line = TypeBuilder::Profiler::LineTick::create()
+                    .setLine(entries[i].line)
+                    .setTicks(entries[i].hit_count);
+                array->addItem(line);

[apavlov, 2014/11/13 09:08:30]

line.release()

[Pan, 2014/11/17 01:14:22]

Done.

+                line.release();

[apavlov, 2014/11/13 09:08:30]

Remove this line, as it makes no sense this way. line.release() derefs line and
returns a PassRefPtr (anyway, the deref will happen automatically when leaving
the scope.)

[Pan, 2014/11/17 01:14:22]

Done.

+            }
+        }
+    }
+    return array;
+}
+
 static PassRefPtr<TypeBuilder::Profiler::CPUProfileNode> buildInspectorObjectFor(const v8::CpuProfileNode* node)
 {
     v8::HandleScope handleScope(v8::Isolate::GetCurrent());
 
     RefPtr<TypeBuilder::Array<TypeBuilder::Profiler::CPUProfileNode> > children = TypeBuilder::Array<TypeBuilder::Profiler::CPUProfileNode>::create();
     const int childrenCount = node->GetChildrenCount();
     for (int i = 0; i < childrenCount; i++) {
         const v8::CpuProfileNode* child = node->GetChild(i);
         children->addItem(buildInspectorObjectFor(child));
     }
 
+    RefPtr<TypeBuilder::Array<TypeBuilder::Profiler::LineTick> > lineTicks = buildInspectorObjectForLineTicks(node);
+
     RefPtr<TypeBuilder::Profiler::CPUProfileNode> result = TypeBuilder::Profiler::CPUProfileNode::create()
         .setFunctionName(toCoreString(node->GetFunctionName()))
         .setScriptId(String::number(node->GetScriptId()))
         .setUrl(toCoreString(node->GetScriptResourceName()))
         .setLineNumber(node->GetLineNumber())
         .setColumnNumber(node->GetColumnNumber())
         .setHitCount(node->GetHitCount())
         .setCallUID(node->GetCallUid())
         .setChildren(children.release())
+        .setLineTicks(lineTicks.release())
         .setDeoptReason(node->GetBailoutReason())
         .setId(node->GetNodeId());
     return result.release();
 }
 
 PassRefPtr<TypeBuilder::Profiler::CPUProfileNode> ScriptProfile::buildInspectorObjectForHead() const
 {
     return buildInspectorObjectFor(m_profile->GetTopDownRoot());
 }
 
 PassRefPtr<TypeBuilder::Array<int> > ScriptProfile::buildInspectorObjectForSamples() const
 {
     RefPtr<TypeBuilder::Array<int> > array = TypeBuilder::Array<int>::create();
     int count = m_profile->GetSamplesCount();
     for (int i = 0; i < count; i++)
         array->addItem(m_profile->GetSample(i)->GetNodeId());
     return array.release();
 }
 
 PassRefPtr<TypeBuilder::Array<double> > ScriptProfile::buildInspectorObjectForTimestamps() const
 {
     RefPtr<TypeBuilder::Array<double> > array = TypeBuilder::Array<double>::create();
     int count = m_profile->GetSamplesCount();
     for (int i = 0; i < count; i++)
         array->addItem(m_profile->GetSampleTimestamp(i));
     return array.release();
 }
 
 } // namespace blink